Bug 231660 - [number format detail] Detail pane implementation needs to protect agsins DSF session shutdown.
Summary: [number format detail] Detail pane implementation needs to protect agsins DSF...
Status: ASSIGNED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf (show other bugs)
Version: 0 DD 1.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Jonah Graham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-12 16:40 EDT by Pawel Piech CLA
Modified: 2020-09-04 15:22 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Piech CLA 2008-05-12 16:40:03 EDT 
This bug is result from review of bug 229812.  The number format detail pane implementation makes an assumption that the DSF session which supplied the selected context will remain active through the process of retrieving the number format data.  There a few specific problems:

1) There are no guards for the case if service returned by DsfServicesTracker was null

2) There is no catch for RejectedExecutionException when submitting runnables to the executor.

3) There request monitor used when calling the services' async methods uses the session executor, which could also throw a rejected execution exception.  

4) The services tracker is never disposed and is called on the non session thread.


To solve these problems I think the implementation should be refactored to use a Sequence and guard agsinst the session being terminated at each step.