Bug 231622 - Some classes from Missing classes from Cntrl-Shift-T
Summary: Some classes from Missing classes from Cntrl-Shift-T
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 critical (vote)
Target Milestone: 3.4 RC1   Edit
Assignee: Jerome Lanneluc CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-12 14:12 EDT by Kevin McGuire CLA
Modified: 2008-05-14 04:47 EDT (History)
4 users (show)

See Also:
david_audel: review+


Attachments
Screen shot showing class is present in explorer but missing from search (392.18 KB, image/jpeg)
2008-05-12 14:12 EDT, Kevin McGuire CLA
no flags Details
Proposed fix and regression test (3.66 KB, patch)
2008-05-13 05:04 EDT, Jerome Lanneluc CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin McGuire CLA 2008-05-12 14:12:01 EDT
Created attachment 99769 [details]
Screen shot showing class is present in explorer but missing from search

build 2008-0510-2000
regression since 0507-2000

1) In a new workspace, open Plug-ins View
2) Select all
3) Add to Java Search
4) Cntrl-Shift-T
5) Type in Workbench.  You should see among other things "WorkbenchStatusDialog" but you will get no hits.  If you reduce it to "Work" you will get some hits but a much much shorter list than you should.

Yet the class *is* there:
6) In Package Explorer, turn off filtering of External Plug-ins
7) Drill down to jar org.eclipse.workbench, package org.eclipse.ui.statushandlers
8) You will see class WorkbenchStatusDialogManager.class

Notes:
A) This is a regression from 0507-2000
B) I've verified this against someone else's Mac install which has been updated regularly via P2

I've tried a few other classes from other plug-ins and can't find them either:
JDT: AnnotationProcessor
PDE : ApiImageDescriptor
Comment 1 Kevin McGuire CLA 2008-05-12 14:28:40 EDT
Update: this ISN'T a regression from 0507

*Restarting* the workspace will make the classes show up.

(It appeared as a regression because 0507 had previously been restarted but the new 0510 hadn't.)
Comment 2 Jerome Lanneluc CLA 2008-05-13 05:04:15 EDT
Created attachment 99906 [details]
Proposed fix and regression test

When changing the classpath through a classpath container, the root infos cache was not marked as stale. Since the workspace scope now uses this cache, types added to a classpath container were not found.
Comment 3 Jerome Lanneluc CLA 2008-05-13 05:04:54 EDT
David, can you please review?
Comment 4 David Audel CLA 2008-05-13 06:01:18 EDT
Patch looks good. +1
Comment 5 Jerome Lanneluc CLA 2008-05-13 09:04:33 EDT
Fix and test released for 3.4RC1
Comment 6 David Audel CLA 2008-05-14 04:47:02 EDT
Verified for 3.4RC1 using I20080513-2000