Bug 231367 - org.eclipse.jdt.compiler.tool is not singleton
Summary: org.eclipse.jdt.compiler.tool is not singleton
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 RC1   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-09 16:06 EDT by Pascal Rapicault CLA
Modified: 2008-05-14 04:41 EDT (History)
3 users (show)

See Also:
jerome_lanneluc: review+

Attachments
Proposed fix (1.42 KB, patch)
2008-05-12 17:52 EDT, Olivier Thomann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Rapicault CLA 2008-05-09 16:06:57 EDT 
I don't know if this is intended or not but I just found out that org.eclipse.jdt.compiler.tool is not singleton.
Comment 1 Olivier Thomann CLA 2008-05-11 14:48:39 EDT 
I don't think it needs to be a singleton since it doesn't provide any extension points.
Comment 2 Jerome Lanneluc CLA 2008-05-12 06:02:26 EDT 
Pascal, why would that be a problem? (naive question from a naive user)
Comment 3 Pascal Rapicault CLA 2008-05-12 14:12:59 EDT 
Because if it happened that two versions of the fragments were installed in OSGi then the framework would just pick the highest version which is not necessarily what you want.
Comment 4 Olivier Thomann CLA 2008-05-12 17:52:52 EDT 
Created attachment 99832 [details]
Proposed fix
Comment 5 Olivier Thomann CLA 2008-05-12 17:53:12 EDT 
Jérôme, please review.
Comment 6 Jerome Lanneluc CLA 2008-05-12 17:56:21 EDT 
Looks good: +1
Comment 7 Olivier Thomann CLA 2008-05-12 18:03:56 EDT 
Released for 3.4RC1.
Comment 8 David Audel CLA 2008-05-14 04:41:42 EDT 
Verified for 3.4RC1 using I20080513-2000