Bug 231227 - [sec] Password recovery question dialog text layout might be improved
Summary: [sec] Password recovery question dialog text layout might be improved
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Security (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 RC1   Edit
Assignee: Security Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 231222 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-05-08 20:24 EDT by Kevin McGuire CLA
Modified: 2008-05-09 15:49 EDT (History)
2 users (show)

See Also:
Kevin_McGuire: review+

Attachments
Screen shot of current dialog with sections highlighted (130.99 KB, image/jpeg)
2008-05-08 20:24 EDT, Kevin McGuire CLA 		no flags Details
The dialog with proposed changes (36.82 KB, image/jpeg)
2008-05-09 13:55 EDT, Oleg Besedin CLA 		no flags Details
Patch (3.70 KB, patch)
2008-05-09 13:57 EDT, Oleg Besedin CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin McGuire CLA 2008-05-08 20:24:28 EDT 
Created attachment 99404 [details]
Screen shot of current dialog with sections highlighted

The dialog for the two Q/A password recovery questions has (I) info in the banner, and help text in the bottom, between the question/answers and the ok/cancel.  See attached image and highlights.

Usually guidance text (telling you what you're supposed to do in this dialog) is in the banner. Plus, the block of permanent text below the main body looks odd from a layout point of view.  Also, the icon change in the banner is typically used for feedback based on user action in the dialog (e.g. error with message for bad field values).

I'm not really sure what the right solution is. Combining the messages might be a solution, but at the risk of the banner getting too wordy.

Given where we are in the cycle this is likely a  post 3.4 item.
Comment 1 Martin Aeschlimann CLA 2008-05-09 04:40:56 EDT 
Here's my suggestion:

Banner Title:
  Password Recovery Setup
Banner Description:
  Specify the questions and answers required for future password recovery.

Description:
 To be able to recover a lost master password for the secure storage, enter two questions and their expected answers.  The questions that will be asked when 'Recover Password' is pressed on the 'Secure Storage' preference page. The answers are case sensitive. 

First Question
Question: Text Input Field
Answer: Text Input Field

Second Question
Question: Text Input Field
Answer: Text Input Field
Comment 2 Oleg Besedin CLA 2008-05-09 13:55:41 EDT 
Created attachment 99522 [details]
The dialog with proposed changes

The dialog with proposed changes and text combined with the text from the bug 231222.
Comment 3 Oleg Besedin CLA 2008-05-09 13:57:12 EDT 
Created attachment 99523 [details]
Patch
Comment 4 Oleg Besedin CLA 2008-05-09 13:57:41 EDT 
Kevin, could you review?
Comment 5 Oleg Besedin CLA 2008-05-09 14:00:25 EDT 
By the way, I did not change labels to be "First question", "Second question" as there is a possibility (not exposed in 3.4) to change the number of questions. So while those labels would look better for simplicity I'd leave them as "Question 1", "Question 2".
Comment 6 Kevin McGuire CLA 2008-05-09 15:05:11 EDT 
+1

Its better.  It still feels a bit odd but maybe I'm just focusing on it too much.  If in 3.5 its still bothering me will open a new bug with a suggested solution.

Btw I notice you have the semicolon fix as I logged in #231222
Comment 7 Oleg Besedin CLA 2008-05-09 15:47:43 EDT 
Patch applied to CVS Head.
Comment 8 Oleg Besedin CLA 2008-05-09 15:49:44 EDT 
*** Bug 231222 has been marked as a duplicate of this bug. ***