Bug 231130 - [spec] IClassFile.getPath() not specified for external class folders
Summary: [spec] IClassFile.getPath() not specified for external class folders
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M1   Edit
Assignee: Jerome Lanneluc CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-08 09:50 EDT by Martin Aeschlimann CLA
Modified: 2008-08-06 13:56 EDT (History)
2 users (show)

See Also:

Attachments
Proposed fix (991 bytes, patch)
2008-06-16 11:51 EDT, Jerome Lanneluc CLA 		no flags Details | Diff
New proposed fix (984 bytes, patch)
2008-06-17 10:49 EDT, Jerome Lanneluc CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Aeschlimann CLA 2008-05-08 09:50:16 EDT 
3.4 M7

The spec of IJavaElement.getPath says:
  * Returns the path to the innermost resource enclosing this element.
  * If this element is not included in an external library,
  * the path returned is the full, absolute path to the underlying resource,
  * relative to the workbench.
  * If this element is included in an external library,
  * the path returned is the absolute path to the archive in the file system.

It doesn't spec what to expect for class files in external folders.
Comment 1 Jerome Lanneluc CLA 2008-06-16 11:51:44 EDT 
Created attachment 105037 [details]
Proposed fix
Comment 2 Martin Aeschlimann CLA 2008-06-16 13:12:55 EDT 
I would suggest to not say 'ZIP archive', but just 'archive'. And there's a typo: Repetition of 'or'. 

+	 * the path returned is the absolute path to the archive or the 
+	 * folder in the file system.
Comment 3 Jerome Lanneluc CLA 2008-06-17 10:49:10 EDT 
Created attachment 105171 [details]
New proposed fix

Thanks Martin. The new proposed fix takes your comment into account.
Comment 4 Jerome Lanneluc CLA 2008-06-25 07:17:33 EDT 
Change released for 3.5M1
Comment 5 Olivier Thomann CLA 2008-08-06 13:56:45 EDT 
Verified for 3.5M1 using I20080805-1307