Bug 230966 - Transforms may fail when more than one bundles contributes various transform types
Summary: Transforms may fail when more than one bundles contributes various transform ...
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Compendium (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.4 RC1   Edit
Assignee: Kim Horne CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-05-07 15:12 EDT by Philippe Ombredanne CLA
Modified: 2008-05-09 05:47 EDT (History)
2 users (show)

See Also:
eclipse: review+
tjwatson: review+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Ombredanne CLA 2008-05-07 15:12:36 EDT
There can be occurences of ArrayOutBound exceptions in org.eclipse.equinox.internal.transforms.TransformInstanceListData:
This fixes it

### Eclipse Workspace Patch 1.0
#P org.eclipse.equinox.transforms.hook
Index: src/org/eclipse/equinox/internal/transforms/TransformInstanceListData.java
===================================================================
RCS file: /cvsroot/eclipse/org.eclipse.equinox/bundles/bundles/org.eclipse.equinox.transforms.hook/src/org/eclipse/equinox/internal/transforms/TransformInstanceListData.java,v
retrieving revision 1.3
diff -u -r1.3 TransformInstanceListData.java
--- src/org/eclipse/equinox/internal/transforms/TransformInstanceListData.java	22 Feb 2008 16:21:53 -0000	1.3
+++ src/org/eclipse/equinox/internal/transforms/TransformInstanceListData.java	7 May 2008 19:11:57 -0000
@@ -139,7 +139,7 @@
 					transformerToTuple.put(type, transforms);
 
 				for (int j = 0; j < transforms.length; j++) {
-					rawTuples.add(transforms[i]);
+					rawTuples.add(transforms[j]);
 				}
 			} catch (IOException e) {
 				e.printStackTrace();
Comment 1 Thomas Watson CLA 2008-05-07 18:09:18 EDT
This seems pretty serious and has a simple fix.  Kim, can you have a look for RC1?
Comment 2 Kim Horne CLA 2008-05-08 09:04:10 EDT
(In reply to comment #1)
> This seems pretty serious and has a simple fix.  Kim, can you have a look for
> RC1?
> 

This looks good for me.  I assume I still need a +1 from someone... if you're okay with it I'll check it in Tom (it'll give me a chance to test out the commit rights. :)
Comment 3 Thomas Watson CLA 2008-05-08 09:47:23 EDT
yup the fix looks good, although I cannot seem to apply the patch directly from the comment.  But it is so simple (change an [i] to [j])

Thanks for the fix Philippe!!  In the future can you please add your patches as attachments.  I think something gets lost in the copy/paste from the browser (at least from Firefox on Windows XP).
Comment 4 Kim Horne CLA 2008-05-08 10:02:28 EDT
(In reply to comment #3)
> yup the fix looks good, although I cannot seem to apply the patch directly from
> the comment.  But it is so simple (change an [i] to [j])
> 
> Thanks for the fix Philippe!!  In the future can you please add your patches as
> attachments.  I think something gets lost in the copy/paste from the browser
> (at least from Firefox on Windows XP).
> 

I had similar issues... I chalked it up to bugzilla wrapping the text in the RCS file: line...

Fix in HEAD!
Comment 5 Philippe Ombredanne CLA 2008-05-09 05:47:44 EDT
sry for the patch copy/paste... I was lazy :-P