Bug 230825 - Fix bugs in DBGP base64 implementations, small optimizations, and tests
Summary: Fix bugs in DBGP base64 implementations, small optimizations, and tests
Status: RESOLVED FIXED
Alias: None
Product: DLTK
Classification: Technology
Component: Common-Debug (show other bugs)
Version: 0.95   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: dltk.common-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-05-07 02:09 EDT by Alex Panchenko CLA
Modified: 2010-06-11 06:32 EDT (History)
2 users (show)

See Also:

Attachments
patch (14.52 KB, patch)
2008-05-07 02:13 EDT, Alex Panchenko CLA 		alex.panchenko: iplog+
Details | Diff
additional patch (903 bytes, patch)
2008-05-07 04:52 EDT, Alex Panchenko CLA 		alex.panchenko: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Panchenko CLA 2008-05-07 02:09:16 EDT 
The base64 responses from "Basic Ruby Debugging Engine" are chunked.
The implementation commited recently does not parse chunked input are throws "IllegalArgumentException: Invalid char to decode: 10".

The patch and tests are attached.

Legal Message: I, Alex Panchenko, declare that I developed attached code from scratch, without referencing any 3rd party materials except material licensed under the EPL. I am authorized by my employer (xored software, Inc.) to make this contribution under the EPL.
Comment 1 Alex Panchenko CLA 2008-05-07 02:13:11 EDT 
Created attachment 99004 [details]
patch
Comment 2 Andrei Sobolev CLA 2008-05-07 03:50:24 EDT 
Applied.
Comment 3 Alex Panchenko CLA 2008-05-07 04:52:42 EDT 
Created attachment 99020 [details]
additional patch

Small addition to the test - it was intended to be there, but I forgot it.
Comment 4 Alex Panchenko CLA 2008-05-07 04:55:22 EDT 
Small addition to the test case. Without it last test does not test the functionality it was supposed to test.
Comment 5 Andrei Sobolev CLA 2008-05-07 05:00:11 EDT 
Applied.
Comment 6 Andrey Platov CLA 2008-05-26 02:48:30 EDT 
bulk change: fixed in 0.95