Bug 230248 - [open plug-in artifact] dialog should sort items better
Summary: [open plug-in artifact] dialog should sort items better
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 RC1   Edit
Assignee: Benjamin Cabé CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, contributed
Depends on:
Blocks:
 
Reported: 2008-05-05 12:32 EDT by Markus Keller CLA
Modified: 2008-05-06 09:55 EDT (History)
2 users (show)

See Also:

Attachments
Screenshot (38.76 KB, image/png)
2008-05-05 12:32 EDT, Markus Keller CLA 		no flags Details
Patch (3.36 KB, patch)
2008-05-05 18:13 EDT, Benjamin Cabé CLA 		no flags Details | Diff
mylyn/context/zip (820 bytes, application/octet-stream)
2008-05-05 18:13 EDT, Benjamin Cabé CLA 		no flags Details
Screenshot *after* (37.98 KB, image/png)
2008-05-06 01:21 EDT, Benjamin Cabé CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2008-05-05 12:32:16 EDT 
Created attachment 98668 [details]
Screenshot

+++ This bug was initially created as a clone of Bug #214246 +++

I20080502-0100

The Open Plug-in Artifact dialog should sort its items
- by kind (done with bug 214246)
- by the fully qualified item name
- by the name of the declaring plug-in (requested but not done with bug 214246)
Comment 1 Chris Aniszczyk CLA 2008-05-05 13:42:39 EDT 
Thanks Markus.

I'm glad to have at least one user of this dialog I created :)
Comment 2 Benjamin Cabé CLA 2008-05-05 13:44:24 EDT 
I'm on bugday every day :p I may have a look soon!
Comment 3 Benjamin Cabé CLA 2008-05-05 18:13:02 EDT 
Created attachment 98727 [details]
Patch

It should now handle all cases explicited in comment 1
Comment 4 Benjamin Cabé CLA 2008-05-05 18:13:07 EDT 
Created attachment 98728 [details]
mylyn/context/zip
Comment 5 Chris Aniszczyk CLA 2008-05-05 18:18:04 EDT 
putting on the RC1 plate
Comment 6 Benjamin Cabé CLA 2008-05-06 01:21:50 EDT 
Created attachment 98749 [details]
Screenshot *after*
Comment 7 Markus Keller CLA 2008-05-06 05:37:43 EDT 
(In reply to comment #6)
The screenshot also shows org.eclipse.core.filebuffers.documentSetup as a match. I guess that's the proposed enhancement from bug 230305 and this will not be released to fix this bug.
Comment 8 Benjamin Cabé CLA 2008-05-06 05:41:32 EDT 
(In reply to comment #7)
> (In reply to comment #6)
> I guess that's the proposed enhancement from bug 230305 and this will
> not be released to fix this bug.

Yap, exactly, well done! Sorry :)
Comment 9 Chris Aniszczyk CLA 2008-05-06 09:55:07 EDT 
Thanks Ben for this last stream of patches :)

Pleasing Markus is key to the PDE mission :P

> 20080506