Description Jacek Pospychala 2008-05-03 12:45:22 EDT

Created attachment 98533 [details]
error log

I have a question to the following condition in org.aspectj.weaver.bcel.BcelShadow.createMethodGen(String, int):

if (resolvedMember != null && Modifier.isProtected(resolvedMember.getModifiers()) && 
!samePackage(targetType.getPackageName(), getEnclosingType().getPackageName()) &&
!resolvedMember.getName().equals("clone")) {


I understand that it's trying to check, if a protected method (resolvedMember) from type (targetType) can be shadowed by another method (aspect) in another type (enclosedType).

Suppose that
resolvedMember is "a.B.test()"
targetType is "a.a.A"
enclosingType is "a.C"

their source is:

--------------- a.a.A ---------------
public class A extends a.B {	
}

--------------- a.B ---------------
public abstract class B {
	protected boolean test() { return true; }
}

--------------- a.C ---------------
public class C {
    protected A a = new A();
    public void run() {
        a.test();
    }
}


then trying to weave something around a.test() call in a.C.run() following check is performed in above condition:

!samePackage(targetType.getPackageName(), getEnclosingType().getPackageName())

which resolves to:

!samePackage("a.a.A".getPackageName(), "a.C".getPackageName())

then 
!samePackage("a.a", "a") = true


It further causes "org.aspectj.weaver.BCException: bad bytecode", which I believe shouldn't happen, if condition was changed from 

!samePackage(targetType.getPackageName(), getEnclosingType().getPackageName())

to:

!samePackage(resolvedMember.getType.getPackageName(), getEnclosingType().getPackageName())




Sorry for such an abstract description but I have quite a difficult setup, hard to extract a self-contained testcase.
I'm attaching log of error that I'm getting right now.
Note, I'm not getting any error if targetType and enclosingType live in the same package.
Please let me know if you have any further questions.