Bug 230072 - [xslt][validation] Project level validation preferences
Summary: [xslt][validation] Project level validation preferences
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.xsl (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P3 enhancement (vote)
Target Milestone: 3.1   Edit
Assignee: David Carver CLA
QA Contact: David Williams CLA
URL:
Whiteboard:
Keywords: noteworthy
Depends on: 232429
Blocks:
  Show dependency tree
 
Reported: 2008-05-03 11:00 EDT by Doug CLA
Modified: 2009-04-30 14:35 EDT (History)
3 users (show)

See Also:


Attachments
My changes on this, so far (63.50 KB, patch)
2008-09-23 17:36 EDT, Jesper Moller CLA
david_williams: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Doug CLA 2008-05-03 11:00:13 EDT
The XSL project should have the ability to configure validation preferences at the project level. This means a property page, and augmenting the existing preference page with a link to configure project-level preferences.
Comment 1 Jesper Moller CLA 2008-05-06 18:23:00 EDT
I'd like to take a stab at this one.
Comment 2 David Carver CLA 2008-05-06 18:34:14 EDT
All yours, Jesper.  Targeted for 0.5M8
Comment 3 Jesper Moller CLA 2008-05-15 19:10:13 EDT
I ran into  a bug re. ScopedPreferenceStore (bug 232429). I might have to work around this first.
Comment 4 David Carver CLA 2008-05-15 20:25:49 EDT
Jesper, you might want to look at how the HTML plugins are doing the project specific validation as well.  Might give you some additional ideas.  HTML preferences for validation can now be set on a per project basis.
Comment 5 David Carver CLA 2008-06-05 21:42:13 EDT
Mass Migration to wtp.inc.xsl
Comment 6 David Carver CLA 2008-09-02 14:49:26 EDT
Jesper is there any update on this?
Comment 7 David Carver CLA 2008-09-20 18:07:27 EDT
Jesper, can you attach what code you have done to date to this bug.   This way Doug or I can try and pick this up and complete it if you don't have time.

Comment 8 David Carver CLA 2008-09-20 18:15:18 EDT
Doug if we don't hear from Jesper soon on this, I think you might be the best person to handle this since you are already familiar with the validation framework.
Comment 9 Jesper Moller CLA 2008-09-23 17:36:39 EDT
Created attachment 113304 [details]
My changes on this, so far

That's a good idea - I'm completely swamped at work (and at home for that matter), so this is just dragging out.

It's pretty close to being done, BUT there's a snag or two. One is that when the defaults and the project-level settings collide, the workspace level defaults end up being used. Another is that (at least on my Mac), I can't seem to grey out the controls properly.
Comment 10 David Carver CLA 2008-09-26 10:34:38 EDT
Thanks Jesper.   We'll see if we can finish this up and polish it.
Comment 11 David Carver CLA 2008-10-08 23:37:07 EDT
I'll see if I can get this finished in the next couple of weeks.
Comment 12 David Carver CLA 2008-10-09 09:16:47 EDT
Jesper, when you were implementing this did you take a look at how the HTML UI plugin implemented it?   They do it a little bit differently.  Just curious.
   
Comment 13 David Carver CLA 2008-10-09 15:31:50 EDT
added initial implementation based partly on Jesper's, Doug's original preference page, and some samples from the HTML plugin.  Only big issues is that the Project Level settings are grayed out...investingating that...all other current implementation code is still working.
Comment 14 David Carver CLA 2008-10-10 12:07:48 EDT
Preference page is in place...fixed issue with Project specific XSLT Validation page being disabled.   Need to update the validation engine so that it checks for project preferences as well as workspace preferences.
Comment 15 David Carver CLA 2008-10-10 12:48:27 EDT
All existing unit tests pass so no known outward changes should be affected by these changes.   I'm going to resolve this for now, and we can open up other bugs to fix specific issues that this change may have caused.  Any new bugs should have corresponding unit tests to verify they are fixed.
Comment 16 David Carver CLA 2009-04-30 14:28:55 EDT
mass update to 3.1 target due to movement from wtp incubator to wtp source editing lost the original milestones.