Bug 230013 - [api][breaking] need to make DStoreKeyStore _instance private
Summary: [api][breaking] need to make DStoreKeyStore _instance private
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.0 M7   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2008-05-02 14:36 EDT by David McKnight CLA
Modified: 2008-05-05 12:18 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David McKnight CLA 2008-05-02 14:36:15 EDT
The DStoreKeyStore instance variable should be private.  This is api breaking but it's unlikely anyone has referenced this directly.
Comment 1 David McKnight CLA 2008-05-02 14:38:45 EDT
I've committed the change to cvs.
Comment 2 David McKnight CLA 2008-05-05 12:18:30 EDT
I also changed the following in ClientConnection so that the following are now final:

	public final static String INCOMPATIBLE_SERVER_UPDATE = "Incompatible DataStore."; //$NON-NLS-1$
	public final static String INCOMPATIBLE_CLIENT_UPDATE = "Incompatible DataStore."; //$NON-NLS-1$
	public final static String SERVER_OLDER = "Older DataStore Server."; //$NON-NLS-1$
	public final static String CLIENT_OLDER = "Older DataStore Client."; //$NON-NLS-1$
	public final static String INCOMPATIBLE_PROTOCOL = "Incompatible Protocol."; //$NON-NLS-1$
	public final static String CANNOT_CONNECT = "Cannot connect to server."; //$NON-NLS-1$