Bug 230001 - Property page contains invalid values
Summary: Property page contains invalid values
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.0 M7   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on: 229610
Blocks:
  Show dependency tree
 
Reported: 2008-05-02 13:41 EDT by Anna Dushistova CLA
Modified: 2008-05-02 17:37 EDT (History)
0 users

See Also:


Attachments
snapshot if error (73.34 KB, image/png)
2008-05-02 13:41 EDT, Anna Dushistova CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Anna Dushistova CLA 2008-05-02 13:41:49 EDT
Created attachment 98471 [details]
snapshot if error

Steps To Reproduce:
1.Create SSH only connection
2.Unfold "SFTP Files", unfold "Root".
3.Select "/" element there, right click, select properties.
It shows "This page contains invalid values" error.
Comment 1 Anna Dushistova CLA 2008-05-02 13:43:10 EDT
Here is exception stack trace from error log:
java.lang.NullPointerException
	at org.eclipse.rse.internal.files.ui.propertypages.SystemFilePropertyPage.createContentArea(SystemFilePropertyPage.java:232)
	at org.eclipse.rse.ui.propertypages.SystemBasePropertyPage.createContents(SystemBasePropertyPage.java:92)
	at org.eclipse.jface.preference.PreferencePage.createControl(PreferencePage.java:235)
	at org.eclipse.jface.preference.PreferenceDialog.createPageControl(PreferenceDialog.java:1462)
	at org.eclipse.jface.preference.PreferenceDialog$13.run(PreferenceDialog.java:1219)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:37)
	at org.eclipse.core.runtime.Platform.run(Platform.java:880)
	at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:48)
	at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:175)
	at org.eclipse.jface.preference.PreferenceDialog.showPage(PreferenceDialog.java:1213)
	at org.eclipse.ui.internal.dialogs.FilteredPreferenceDialog.showPage(FilteredPreferenceDialog.java:456)
	at org.eclipse.jface.preference.PreferenceDialog$9.selectionChanged(PreferenceDialog.java:698)
	at org.eclipse.jface.viewers.StructuredViewer$3.run(StructuredViewer.java:842)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:37)
	at org.eclipse.core.runtime.Platform.run(Platform.java:880)
	at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:48)
	at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:175)
	at org.eclipse.jface.viewers.StructuredViewer.firePostSelectionChanged(StructuredViewer.java:840)
	at org.eclipse.jface.viewers.StructuredViewer.setSelection(StructuredViewer.java:1639)
	at org.eclipse.jface.viewers.TreeViewer.setSelection(TreeViewer.java:1098)
	at org.eclipse.jface.preference.PreferenceDialog.selectSavedItem(PreferenceDialog.java:1015)
	at org.eclipse.ui.internal.dialogs.FilteredPreferenceDialog.selectSavedItem(FilteredPreferenceDialog.java:499)
	at org.eclipse.jface.preference.PreferenceDialog$4.run(PreferenceDialog.java:369)
	at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:67)
	at org.eclipse.jface.preference.PreferenceDialog.createContents(PreferenceDialog.java:365)
	at org.eclipse.jface.window.Window.create(Window.java:431)
	at org.eclipse.jface.dialogs.Dialog.create(Dialog.java:1089)
	at org.eclipse.ui.internal.dialogs.PropertyDialog.createDialogOn(PropertyDialog.java:82)
	at org.eclipse.ui.dialogs.PropertyDialogAction.createDialog(PropertyDialogAction.java:176)
	at org.eclipse.ui.dialogs.PropertyDialogAction.run(PropertyDialogAction.java:155)
	at org.eclipse.jface.action.Action.runWithEvent(Action.java:498)
	at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:582)
	at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:499)
	at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:410)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:83)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1145)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3370)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3002)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2351)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2315)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2181)
	at org.eclipse.ui.internal.Workbench$4.run(Workbench.java:477)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:288)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:472)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:112)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:193)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:375)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:175)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:585)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:549)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:504)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1236)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1212)
Comment 2 Martin Oberhuber CLA 2008-05-02 13:51:53 EDT
DaveM should be looking at this, related to bug 229610.
Comment 3 David McKnight CLA 2008-05-02 16:14:11 EDT
The problem was that we were trying to determine the default encoding from the parent file.  However "/" doesn't have a parent - hence the null pointer exception.  In the case where the parent is null, we'll use the subsystem remote encoding.
Comment 4 Martin Oberhuber CLA 2008-05-02 16:54:42 EDT
Why do we need to look for the parent, when the resource kind is a folder?
Shouldn't a folder's encoding be specified by itself, rather than looking at the parent?

Actually I don't even understand why we need to look at the parent of files, shouldn't they have an encoding specified by themselves?
Comment 5 David McKnight CLA 2008-05-02 16:59:18 EDT
(In reply to comment #4)
> Why do we need to look for the parent, when the resource kind is a folder?
> Shouldn't a folder's encoding be specified by itself, rather than looking at
> the parent?
> Actually I don't even understand why we need to look at the parent of files,
> shouldn't they have an encoding specified by themselves?

We're looking at the parent to determine what the file/folder would default to if the user chooses to not explicitly specify an encoding.
Comment 6 Martin Oberhuber CLA 2008-05-02 17:37:26 EDT
I see. Makes sense, thanks.