Bug 229968 - Perf regression while computing type hierarchy
Summary: Perf regression while computing type hierarchy
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 RC1   Edit
Assignee: Jerome Lanneluc CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-02 10:53 EDT by Jerome Lanneluc CLA
Modified: 2008-05-13 10:55 EDT (History)
2 users (show)

See Also:
frederic_fusier: review+

Attachments
Proposed fix (3.61 KB, patch)
2008-05-02 11:31 EDT, Jerome Lanneluc CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jerome Lanneluc CLA 2008-05-02 10:53:39 EDT 
I20080502-0100

FullSourceWorkspaceTypeHierarchyTests.testPerfAllTypes() shows a performance regression around 3%.
Comment 1 Jerome Lanneluc CLA 2008-05-02 11:24:24 EDT 
As the consequence of the fix for bug 182738, the order of path returned by JavaWorkspaceScope#enclosingProjectAndJars() is different. The HandleFactory walks this list and performance is affected because of the different ordering.
Comment 2 Jerome Lanneluc CLA 2008-05-02 11:31:35 EDT 
Created attachment 98449 [details]
Proposed fix

This fix avoids the walking of the enclosingProjectsAndJars() by asking the scope directly for the package fragment root.
Comment 3 Jerome Lanneluc CLA 2008-05-05 04:43:40 EDT 
With this fix, performance of type hierarchy is back to 3.3 performance. Frederic can you please review?
Comment 4 Frederic Fusier CLA 2008-05-05 10:41:33 EDT 
The patch looks good to me.
Comment 5 Jerome Lanneluc CLA 2008-05-06 04:38:05 EDT 
Released for 3.4RC1.

To verify, check the performance results for FullSourceWorkspaceTypeHierarchyTests#testPerfAllTypes() in 
<download_server>/downloads/drops/S-3.4M7-200805020100/performance/org.eclipse.jdt.core.php?
Comment 6 David Audel CLA 2008-05-13 10:55:44 EDT 
Verified for 3.4RC1.