Description Mariot Chauvin 2008-05-02 05:19:47 EDT

By running the SAP memory analyser tool (http://www.eclipse.org/mat/), I remarked that most instances of org.eclipse.gmf.runtime.diagram.ui.editpolicies.PopupBarEditPolicy have an empty imageimagesToBeDisposed array list.

Below is the current initialization :

/** Images created that must be deleted when popup bar is removed */
protected List imagesToBeDisposed = new ArrayList();

To avoid memory wasted it would be nice to have a lazy initialization :

...
myDisabledImage = new Image(Display.getCurrent(), theImage, SWT.IMAGE_DISABLE);
if (imageToBeDisposed == null)
   imageToBeDisposed = new ArrayList(); 
imagesToBeDisposed.add(myDisabledImage);
...