Bug 229728 - uppercase .WSDL cannot be found by the Web Service Client wizard
Summary: uppercase .WSDL cannot be found by the Web Service Client wizard
Status: CLOSED FIXED
Alias: None
Product: WTP Webservices
Classification: WebTools
Component: jst.ws (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 RC1   Edit
Assignee: Andrew Mak CLA
QA Contact: Kathy Chan CLA
URL:
Whiteboard: PMC_APPROVED
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-04-30 17:43 EDT by Kathy Chan CLA
Modified: 2008-06-09 13:07 EDT (History)
2 users (show)

See Also:
kathy: pmc_approved? (david_williams)
kathy: pmc_approved? (raghunathan.srinivasan)
kathy: pmc_approved? (naci.dai)
kathy: pmc_approved? (deboer)
kathy: pmc_approved? (neil.hauge)
kaloyan: pmc_approved+

Attachments
Fixes .WSDL and .WSIL (9.89 KB, patch)
2008-05-01 13:08 EDT, Andrew Mak CLA 		bjorn.freeman-benson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kathy Chan CLA 2008-04-30 17:43:02 EDT 
If the a webservice file is using a uppercase for the extension .WSDL
then the Web Service Client wizard does not find the resource
Steps to reproduce:
Create a webservice definition file with an uppercase       
Right click on the file and select Webservices > Generate Client
Result:
Service definition field is not populated.
Browsing to find the file will not allow you to select the file
located in the workspace.                                            

Workaround:
Change the extension to lowercase .wdl
Comment 1 Andrew Mak CLA 2008-05-01 11:23:12 EDT 
Additionally, there are a few places where .WSIL is not handled by the Web services tools.
Comment 2 Andrew Mak CLA 2008-05-01 13:08:40 EDT 
Created attachment 98339 [details]
Fixes .WSDL and .WSIL
Comment 3 Andrew Mak CLA 2008-05-01 13:11:31 EDT 
Also fixed .XSD in one place in WSDLCopier
Comment 4 Andrew Mak CLA 2008-05-06 15:16:38 EDT 
Problem:
There are several areas in the Web service wizards that does not allow uppercase WSDL/WSIL files to be picked even though the files are valid (i.e. you can open a .WSDL file in the WSDL editor with no problem).

Fix:
The fix is to use equalsIgnoreCase() or toLower() as appropriate to ensure that the Web service wizards will tolerate WSDL/WSIL files.  This fix is only needed for determine whether the selection is valid.  Once we are able to select these files, the Web service tools itself actually already works for WSDL/WSIL files.

Testing:
I've tested our usual top-down, buttom-up, client scenarios and also the generate wsil scenario as well.

Review:
Kathy, please review this patch.
Comment 5 Kathy Chan CLA 2008-05-07 10:57:25 EDT 
Patch looks good.  Thanks Andrew!

PMC, please approve for WTP 3.0 RC1.
Comment 6 Kaloyan Raev CLA 2008-05-07 11:03:59 EDT 
Approved.
Patch looks simple and it seems that the WS team is convinced that it should go in 3.0.
Comment 7 Kathy Chan CLA 2008-05-08 17:30:55 EDT 
Patch committed and released to HEAD as v200805082126.
Comment 8 Kathy Chan CLA 2008-06-09 13:07:32 EDT 
Verified on WTP 3.0 06/08.