Bug 229683 - [formatter] New comment formatter takes 2 passes to format when tags are inside text
Summary: [formatter] New comment formatter takes 2 passes to format when tags are insi...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 RC1   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-30 13:42 EDT by Frederic Fusier CLA
Modified: 2008-05-13 06:08 EDT (History)
3 users (show)

See Also:
jerome_lanneluc: review+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Frederic Fusier CLA 2008-04-30 13:42:08 EDT
Using build 20080427-2000.

The new comment formatter needs 2 passes to format the following test case:
public class X {
	/**
	 * Returns a complete node containing the contents of the subtree 
	 * rooted at @key in the receiver.  Uses the public API.
	 *
	 * @param key
	 *	key of subtree whose contents we want to copy.
	 */
	void foo(String key) {
	}
}
Comment 1 Frederic Fusier CLA 2008-05-06 05:50:01 EDT
The patch fixing this issue has been attached to bug 230230.
Jerome can you please review?
Comment 2 Frederic Fusier CLA 2008-05-06 07:08:29 EDT
Released for 3.4RC1 in HEAD stream.
Comment 3 Eric Jodet CLA 2008-05-13 06:08:31 EDT
Verified for 3.4RC1 using build I20080510-2000.

Note that expected output after the single pass formatting is:

/**
 * Returns a complete node containing the contents of the subtree rooted at @key
 * in the receiver. Uses the public API.
 * 
 * @param key
 *      key of subtree whose contents we want to copy.
 */