Bug 229486 - [disassembly][breakpoints] Problem when setting an address breakpoint from the Disassembly view
Summary: [disassembly][breakpoints] Problem when setting an address breakpoint from th...
Status: CLOSED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf (show other bugs)
Version: 0 DD 1.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: DD 1.0   Edit
Assignee: DD General Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-04-29 17:37 EDT by Francois Chouinard CLA
Modified: 2009-01-07 17:01 EST (History)
2 users (show)

See Also:

Attachments
Fix for setting address breakpoints (+committed, +logged) (96.16 KB, patch)
2008-04-30 08:02 EDT, Anton Leherbauer CLA 		pawel.1.piech: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Francois Chouinard CLA 2008-04-29 17:37:11 EDT 
To reproduce:
- Set an address breakpoint from the DSF Disassembly View

The MIBreakpointsManager.breakpointAdded() is called but the test for a valid debugger path fails and the breakpoint is not inserted at the back-end. An error (No debugger path for breakpoint) is also logged in the Errors View.

Furthermore, the platform breakpoint is persisted on exit and, in subsequent restart, failure to re-install the breakpoint hangs the launch sequence (same debugger path error).

Enabling/Disabling/Modifying the breakpoint also generate errors.
Comment 1 Anton Leherbauer CLA 2008-04-30 08:02:06 EDT 
Created attachment 98148 [details]
Fix for setting address breakpoints (+committed, +logged)

This patch addresses the issues when setting an address breakpoint and adds the test org.eclipse.dd.tests.gdb.MIBreakpointsTest.insertBreakpoint_Address().

The new CDT event breakpoints are also handled more gracefully (i.e. ignored).
Comment 2 Francois Chouinard CLA 2008-04-30 15:58:54 EDT 
Thanks Anton.

I will commit your patch.

BR,
/fc
Comment 3 Pawel Piech CLA 2008-05-07 16:13:56 EDT 
Hi Francoic,
Since you reviewed the patch, please mark it verified.
Comment 4 Pawel Piech CLA 2008-08-13 13:05:27 EDT 
Closing out 1.0 bugs.