Bug 229373 - [formatter] New comment formatter gets lost when encountering invalid closing tags
Summary: [formatter] New comment formatter gets lost when encountering invalid closing...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M7   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-29 11:57 EDT by Frederic Fusier CLA
Modified: 2008-05-02 11:44 EDT (History)
1 user (show)

See Also:

Attachments
Test case to illustrate the problem (451 bytes, text/x-java)
2008-04-29 11:57 EDT, Frederic Fusier CLA 		no flags Details
Proposed patch (3.72 KB, patch)
2008-04-29 12:14 EDT, Frederic Fusier CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frederic Fusier CLA 2008-04-29 11:57:16 EDT 
Created attachment 98011 [details]
Test case to illustrate the problem

Using build I20080427-2000.

The new comment formatter does not correctly format the attached test case.

As there are two closing </code> tags instead of opening-closing tags (e.g. <code>...</code>), the formatter lost the correct html tags levels and the output is severely broken!
Comment 1 Frederic Fusier CLA 2008-04-29 11:58:46 EDT 
The problem is in html tags verification of the FormatterCommentParser...
Comment 2 Frederic Fusier CLA 2008-04-29 12:14:36 EDT 
Created attachment 98016 [details]
Proposed patch
Comment 3 Frederic Fusier CLA 2008-04-29 12:23:24 EDT 
Released for 3.4M7 in HEAD stream.
Comment 4 Kent Johnson CLA 2008-05-02 11:44:26 EDT 
Verified for 3.4M7 using I20080502-1000