Community
Participate
Working Groups
Miner threads are not terminated even after clients disconnect the server in multithread environment. This is a problem in multithread server (a single-process server).
Created attachment 97826 [details] patch to terminate miner threads Legal Message: I, {Noriaki Takatsu}, declare that I developed attached code from scratch, without referencing any 3rd party materials except material licensed under the EPL. I am authorized by my employer to make this contribution under the EPL.
I've committed the fix to cvs.
Please, PLEASE, don't forget setting the "contributed" keyword for contributed patches as soon as they are committed to CVS. It's part of our IP due diligence to keep track of any non-committer contributions. Because it's so important, we're doing the "double bookkeeping" in both the tm-log.csv and the bugzilla contributed keyword. In the end, a bugzilla query needs to return the same list of contributions as the tm-log.csv. I'm trying to keep an eye on this, but I also cannot review each and every contribution. Please be diligent yourselves and do BOTH adding the keyword AND updating the tm-log.csv when committing a contributed patch. We need this little extra effort. Thanks.
In order to make sure that everybody understands the duties of super.finish(), I added following Javadoc to the Miner.finish() code: * <p> * Subclasses may override this method but must call * <code>super.finish()</code> at the end of their overriding method. We should be adding such a paragraph wherever we expect subclasses not to override a method, but rather to extend it. See also AbstractService#initService() AbstractService#uninitService() for example. Please remember adding such comments wherever a super() call is required or expected by the declaring method to be overridden.
