Bug 228781 - Mapping File wizard: no warning for non-source folder
Summary: Mapping File wizard: no warning for non-source folder
Status: VERIFIED FIXED
Alias: None
Product: Dali JPA Tools
Classification: WebTools
Component: General (show other bugs)
Version: 2.0   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 2.0.1   Edit
Assignee: Paul Fullbright CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-24 17:51 EDT by Paul Fullbright CLA
Modified: 2008-08-21 17:47 EDT (History)
2 users (show)

See Also:
neil.hauge: review+

Attachments
proposed patch (1.29 KB, patch)
2008-07-21 15:04 EDT, Paul Fullbright CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Fullbright CLA 2008-04-24 17:51:32 EDT 
A warning is given for a non-existent folder (we'll actually create it), but no warning (or error) is given for a non-source folder (we currently don't actually change it to being a source folder).
Comment 1 Paul Fullbright CLA 2008-04-29 11:21:16 EDT 
Fix committed to head.
Comment 2 Karen Butzke CLA 2008-06-04 13:46:08 EDT 
There is a warning now, but the Finish button is enabled.  Probably needs to be an error and the Finish button disabled.  If you press finish several exceptions get thrown:

java.lang.NullPointerException
at org.eclipse.jpt.core.internal.operations.OrmFileCreationOperation.createOrmXml(OrmFileCreationOperation.java:130)
at org.eclipse.jpt.core.internal.operations.OrmFileCreationOperation.execute(OrmFileCreationOperation.java:54)
at org.eclipse.wst.common.frameworks.internal.datamodel.DataModelPausibleOperationImpl$1.run(DataModelPausibleOperationImpl.java:376)
at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:1800)


org.eclipse.ui.PartInitException: Unable to open external editor for C:/MyTestWorkspace/TestProject/srct/META-INF/orm.xml.
at org.eclipse.ui.internal.EditorManager.openSystemExternalEditor(EditorManager.java:880)
at org.eclipse.ui.internal.EditorManager.openEditorFromDescriptor(EditorManager.java:663)
at org.eclipse.ui.internal.EditorManager.openEditor(EditorManager.java:639)
Comment 3 Paul Fullbright CLA 2008-07-21 15:04:56 EDT 
Created attachment 107986 [details]
proposed patch

Same patch as for bug 228783.  Simply changing two warning cases to error cases.
Comment 4 Paul Fullbright CLA 2008-07-22 17:51:29 EDT 
Committed patch to maintenance branch and head.
Comment 5 Neil Hauge CLA 2008-08-21 17:47:28 EDT 
Verified in wtp-sdk-R-3.0.1-20080818032401.