Bug 228648 - AST: no binding for Javadoc reference to inner class
Summary: AST: no binding for Javadoc reference to inner class
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 RC2   Edit
Assignee: Eric Jodet CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-24 07:19 EDT by Martin Aeschlimann CLA
Modified: 2008-05-23 05:46 EDT (History)
4 users (show)

See Also:
eric_jodet: review+
eric_jodet: review+

Attachments
[proposed patch + test case] on top v865 (3.52 KB, patch)
2008-05-20 10:03 EDT, Eric Jodet CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Aeschlimann CLA 2008-04-24 07:19:56 EDT 
20080424

- create the following 2 classes:
package p3;
public class B {
	class Inner {	
	}
}

package p3;
import p3.B.Inner;
/**
 * {@link #foo(Inner)}
 * {@link #foo2(B)}
 */
public class A {
	public void foo(Inner inner) {
	}
	public void foo2(B b) {
	}
}

- open the AST view on 'Inner' in '#foo(Inner)':
The node has no binding.
Hover works. It also works for {@link #foo2(B)}, so I assume it has to do something with the inner class.

The missing binding prevent linked rename to work correctly.
Also the quick fix to add the missing qualification to Inner (if compliance == 1.4) doesn't show up.
Comment 1 Eric Jodet CLA 2008-05-20 10:01:43 EDT 
Inner' in '#foo(Inner)' node has no binding as soon as compliance is 1.4.
Bindings are ok for compliance > 1.4

bug introduced at 3.4 M3 while fixing bug 195374
Comment 2 Eric Jodet CLA 2008-05-20 10:03:08 EDT 
Created attachment 101038 [details]
[proposed patch + test case] on top v865
Comment 3 Eric Jodet CLA 2008-05-20 10:04:50 EDT 
(In reply to comment #2)
with this fix:
- still report the unresolved reference at 1.4 compliance as requested by bug 195374
- resolve the bindings
Comment 4 Eric Jodet CLA 2008-05-20 10:55:53 EDT 
(In reply to comment #2)
passes all jdt.core, ui and text tests
Comment 5 Jerome Lanneluc CLA 2008-05-21 05:23:06 EDT 
Since this is a regression comparing to 3.3.2, and the patch is quite simple, we should target it for 3.4RC2. Eric, please ask for the reviews of the patch.
Comment 6 Eric Jodet CLA 2008-05-21 05:30:44 EDT 
Frederic, may you please review proposed correction? thanks
Comment 7 Eric Jodet CLA 2008-05-21 06:28:27 EDT 
(In reply to comment #6)
Jerome, may you also please review? thanks
Comment 8 Frederic Fusier CLA 2008-05-21 06:40:20 EDT 
Patch looks good: +1

However, while reviewing the patch, I discovered a problem on the fix released for the initial bug 195374. The types partially qualified are warned by the javadoc tool but not by the JDT compiler. I have opened bug 233187 for this issue...
Comment 9 Jerome Lanneluc CLA 2008-05-21 08:44:18 EDT 
Patch looks good: +1
Comment 10 Eric Jodet CLA 2008-05-21 08:56:06 EDT 
patch released in HEAD for 3.4RC2
Comment 11 Eric Jodet CLA 2008-05-21 09:04:50 EDT 
(refresh issue)
Comment 12 Frederic Fusier CLA 2008-05-23 05:46:02 EDT 
Verified for 3.4RC2 using I20080523-0100.