Bug 228639 - Source attachment root detection doesn't work if source folder contains META-INF
Summary: Source attachment root detection doesn't work if source folder contains META-INF
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M7   Edit
Assignee: Jerome Lanneluc CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-24 06:01 EDT by Jerome Lanneluc CLA
Modified: 2008-04-29 09:55 EDT (History)
0 users

See Also:

Attachments
Proposed fix and regression test (4.49 KB, patch)
2008-04-24 06:58 EDT, Jerome Lanneluc CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jerome Lanneluc CLA 2008-04-24 06:01:15 EDT 
I20080422

1. Have org.eclipse.jdt.compiler.tool v_854 in your dev workspace
2. Start a runtime workbench
3. Load org.eclipse.jdt.ui v20080422-0800 from CVS
4. Open type org.eclipse.jdt.internal.compiler.tool.Archive.class
Observe: No source is displayed for this type
Comment 1 Jerome Lanneluc CLA 2008-04-24 06:58:04 EDT 
Created attachment 97424 [details]
Proposed fix and regression test
Comment 2 Jerome Lanneluc CLA 2008-04-24 09:20:44 EDT 
Fix and test released for 3.4M7
Comment 3 Maxime Daniel CLA 2008-04-29 09:55:57 EDT 
The initial scenario does not work indeed, but the test case of comment #1 works. Discussed with Jérôme and opened bug 229304 for the scenario breakage, which is not source-attachment related.
A validation scenario that would work is the following:

1. Have org.eclipse.jdt.compiler.tool v_854 in your dev workspace
2. Start a runtime workbench (further steps all use that workbench)
3. Load org.eclipse.jdt.ui v20080422-0800 from CVS
4. Expand its Plug-in Dependencies
5. In the Package Explorer, drill down upon 'bin [path depends on your disk layout]/org.eclipse.jdt.internal.compiler.tool/Archive.class' file
6. Double-click on it

Expected: an editor opens upon its attached source.
Result using org.eclipse.jdt.core dated 20080422: a class file editor opens instead.

I20080427-2000 behaves as expected, hence:

Verified for 3.4 M7 using build I20080427-2000.