Bug 228582 - add editor context menu contributions for PDT editors
Summary: add editor context menu contributions for PDT editors
Status: RESOLVED WONTFIX
Alias: None
Product: ECF
Classification: RT
Component: ecf.ui (show other bugs)
Version: 1.2.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 2.0.0M7   Edit
Assignee: ecf.core-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2008-04-23 22:30 EDT by Scott Lewis CLA
Modified: 2014-05-09 13:44 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Lewis CLA 2008-04-23 22:30:58 EDT 
Users of PDT would like to use the ECF editor sharing (and resource sharing).  The easiest way to enable this would be to add markup to allow for PDT editor menu contributions when PDT editors are available.
Comment 1 Remy Suen CLA 2008-04-23 22:41:49 EDT 
Is there an associated reference bug to this or something?
Comment 2 Scott Lewis CLA 2008-04-24 10:09:31 EDT 
> Is there an associated reference bug to this or something?

No, it should have been entered as enhancement.


It seems that the PDT php editor actually uses the context from the WTP StructuredTextEditor.  If I added markup like the following to our example collab application:

   <!-- php editor -->
   <extension
         point="org.eclipse.ui.menus">
      <menuContribution
            locationURI="popup:org.eclipse.wst.sse.ui.StructuredTextEditor.EditorContext?after=additions">
         <dynamic
               class="org.eclipse.ecf.internal.example.collab.EditorCompoundContributionItem"
               id="org.eclipse.ecf.example.collab.structuredtexteditorcontribution">
         </dynamic>
      </menuContribution>
   </extension>

Note the locationURI.  This specifies the StructuredTextEditor.EditorContext for this contribution.

With this markup the ECF menu contribution *does* appear in PDT's php editor context menu.  The nice thing about this, is that if other editors based upon wst's StructuredTextEditor are present, then they will also show these menu contributions and be able to use them!  So this should make a number of other editors (all those that use or extend wst StructuredTextEditorContext) without further additions.

I've committed this addition to HEAD, and this will be in the 4/24/2008 daily build for testing.
Comment 3 Scott Lewis CLA 2014-05-09 13:44:29 EDT 
Resolving as wontfix due to resources.  If contributor or committer resources become available then please reopen.