Bug 228473 - [Refactoring] HideMethodRefactoring messages
Summary: [Refactoring] HideMethodRefactoring messages
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-core (show other bugs)
Version: 5.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 5.0 M7   Edit
Assignee: Markus Schorn CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-04-23 13:51 EDT by Vivian Kong CLA
Modified: 2009-01-09 17:06 EST (History)
3 users (show)

See Also:

Attachments
patch (11.93 KB, patch)
2008-04-24 05:28 EDT, Emanuel Graf CLA 		bjorn.freeman-benson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vivian Kong CLA 2008-04-23 13:51:55 EDT 
Just a minor issue with the bundle name for HideMethodRefactoring messages.  It should be "org.eclipse.cdt.internal.ui.refactoring.hidemethod.messages" instead of "org.eclipse.cdt.hsrrefactoring.hidemethod.messages".

There's also a spelling error for HideMethodRefactoring_NoMethodNameSelected.
Comment 1 Vivian Kong CLA 2008-04-23 13:59:03 EDT 
Bundle name for GetterandSetter needs to change as well, from "org.eclipse.cdt.hsrrefactoring.generategettersandsetters.messages" to "org.eclipse.cdt.internal.ui.refactoring.gettersandsetters.messages".
Comment 2 Emanuel Graf CLA 2008-04-24 02:33:42 EDT 
I fix this.
Comment 3 Emanuel Graf CLA 2008-04-24 05:28:48 EDT 
Created attachment 97410 [details]
patch

I found amd fixed some other HSR leftovers in org.eclipse.cdt.internal.ui.refactoring.Messages
Comment 4 Markus Schorn CLA 2008-04-24 06:56:52 EDT 
Thanks, I have committed the patch,
fixed in 5.0 > 20080424.
Comment 5 Doug Schaefer CLA 2008-06-03 15:28:48 EDT 
assigning
Comment 6 Doug Schaefer CLA 2008-06-03 15:29:06 EDT 
done
Comment 7 Doug Schaefer CLA 2008-06-03 15:29:19 EDT 
and I mean really done...