Community
Participate
Working Groups
+++ This bug was initially created as a clone of Bug #228230 +++ FTPService and SftpFileService currently create SystemMessage("RSE", "F","9999"...) I think that they should use a SimpleSystemMessage Constructor as per the Javadocs of SimpleSystemMessage, including a plug-in ID and plug-in-specific error code.
Dave can you please fix this properly? I guess you're the one who would best know what ID's should go into a SimpleSystemMessage here, thanks.
These occurrences are as follows: In FTPService: protected String checkEncoding(String s) throws SystemMessageException { ... catch(UnsupportedEncodingException e) { SystemMessage msg = new SystemMessage("RSE","F","9999",'E',e.getMessage(),""); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ //$NON-NLS-4$ throw new SystemMessageException(msg); } } In SFtpFileService: protected String recodeSafe(String s) throws SystemMessageException { ... } catch(UnsupportedEncodingException e) { //SystemMessage msg = new SystemMessage("RSE","F","9999",'E',e.getMessage(),"Please specify a different encoding in host properties."); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ //$NON-NLS-4$ SystemMessage msg = new SystemMessage("RSE","F","9999",'E',e.getMessage(),""); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ //$NON-NLS-4$ //throw new RemoteFileIOException(new SystemMessageException(msg)); throw new SystemMessageException(msg); } I don't think we have any message IDs for unsupported encoding exceptions.
Well it doesn't need to be a globally unique ID, does it? But anything that correctly uses the SimpleSystemMessage API properly would be better than what we have now, wouldn't it? Because the current code creates fake globally unique ID's that are simply incorrect. That being said, I'm surprised that no message ID exists for unsupported encoding problems, since that should be something quite likely to occur with all the recoding that we're doing for DStore?
Bulk moving 3.3 deferred items to 3.3.1
Clearing target milestone
