Bug 228062 - [run control][disassembly] Integrate DSF with CDT's toggle instruction step mode action.
Summary: [run control][disassembly] Integrate DSF with CDT's toggle instruction step m...
Status: CLOSED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf (show other bugs)
Version: 0 DD 1.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: DD 1.0   Edit
Assignee: DD General Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on: 228063
Blocks:
  Show dependency tree
 
Reported: 2008-04-21 13:35 EDT by Pawel Piech CLA
Modified: 2009-01-07 17:05 EST (History)
1 user (show)

See Also:

Attachments
Integrate with CDT step mode action (+committed, +logged) (40.26 KB, patch)
2008-05-06 06:32 EDT, Anton Leherbauer CLA 		pawel.1.piech: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Piech CLA 2008-04-21 13:35:52 EDT 
There are two interfaces in CDT which deal with instruction stepping: ISteppingModeTarget and ITargetProperties.  The former allows the toggle stepping mode action to set the stepping mode.  The latter allows the toggle action to update when another action changes the stepping mode.  Both interfaces need to be implemented by an adapter in DSF and linked to the step action targets.
Comment 1 Anton Leherbauer CLA 2008-05-06 06:32:53 EDT 
Created attachment 98787 [details]
Integrate with CDT step mode action (+committed, +logged)

This patch connects the DSF step actions to the CDT step mode toggle button. Note that this does not yet work with CDT 5.0 M7, but only with builds > 20080506.
Comment 2 Pawel Piech CLA 2008-05-06 13:14:21 EDT 
Thanks Toni, I will take a look at this patch as soon as I'm finished with M7 testing.
Comment 3 Pawel Piech CLA 2008-05-07 13:41:32 EDT 
Nice!  I committed  the patch as is.
Comment 4 Pawel Piech CLA 2008-05-07 13:46:06 EDT 
Verified.  
I filed bug 230948 for adding persistence which can be addressed in a future release.
Comment 5 Pawel Piech CLA 2008-08-13 13:06:41 EDT 
Closing out 1.0 bugs.