Bug 228054 - NPE in ClientRuntimeSelectionWidgetDefaultingCommand
Summary: NPE in ClientRuntimeSelectionWidgetDefaultingCommand
Status: CLOSED FIXED
Alias: None
Product: WTP Webservices
Classification: WebTools
Component: jst.ws (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 M7   Edit
Assignee: Andrew Mak CLA
QA Contact: Kathy Chan CLA
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-04-21 12:59 EDT by Andrew Mak CLA
Modified: 2008-05-21 16:58 EDT (History)
0 users

See Also:

Attachments
check for null (1.55 KB, patch)
2008-04-21 14:06 EDT, Andrew Mak CLA 		no flags Details | Diff
check for null (1.71 KB, patch)
2008-04-21 14:07 EDT, Andrew Mak CLA 		bjorn.freeman-benson: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Mak CLA 2008-04-21 12:59:47 EDT 
In ClientRuntimeSelectionWidgetDefaultingCommand.getServerFromProject(String, FacetMatcher) method, FacetMatcher can be null in which case, an NPE occurs on line 572 because it is not checked for null:

    if (facetMatcher.getFacetsToAdd() != null)
Comment 1 Andrew Mak CLA 2008-04-21 14:06:01 EDT 
Created attachment 96903 [details]
check for null
Comment 2 Andrew Mak CLA 2008-04-21 14:07:15 EDT 
Created attachment 96905 [details]
check for null

Previous was wrong patch.
Comment 3 Kathy Chan CLA 2008-04-21 18:13:08 EDT 
Patch committed and released to HEAD as v200804212121.
Comment 4 David Williams CLA 2008-04-24 00:44:51 EDT 
mass change to add 'contributed' keyword based on bugzilla query, please correct if that's not accurate (by marking patches as obsolete and removing the 'contributed' keyword.
Comment 5 Andrew Mak CLA 2008-05-21 16:58:35 EDT 
Verified on S-3.0M7-20080506040630