Bug 227689 - New plugins from existing jar wizard doesn't enable the 'Finish' button.
Summary: New plugins from existing jar wizard doesn't enable the 'Finish' button.
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M7   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2008-04-17 20:29 EDT by Raghunathan Srinivasan CLA
Modified: 2008-04-24 04:35 EDT (History)
2 users (show)

See Also:


Attachments
Patch (1.91 KB, patch)
2008-04-23 15:54 EDT, Curtis Windatt CLA
no flags Details | Diff
mylyn/context/zip (1.58 KB, application/octet-stream)
2008-04-24 04:35 EDT, Chris Aniszczyk CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Raghunathan Srinivasan CLA 2008-04-17 20:29:49 EDT
Build
Version: 3.4.0
Build id: I20080409-1425

1) Empty Workspace
2) Follow steps in http://wiki.eclipse.org/Adding_Bundles_to_Orbit:
Use this approach when you have a library (i.e., JAR) that you want to convert into a bundle.

   1. Create a new project or new branch of an existing project to hold the bundle's content.
   2. Start the New > Project > Plugin Development > Plug-in from existing JAR wizard to effectively import the library into a new project.
   3. Enter the new bundle name etc.
   4. Ensure that the Analyze library contents and add dependencies checkbox is selected.
   5. Ensure that the Unzip the JAR into the project checkbox is selected.
   6. Click Finish 

Note: The Finish button is not enabled. In the page titled, 'Update Java Classpath', there are no plugins to select since its an empty ws.
Comment 1 Chris Aniszczyk CLA 2008-04-17 23:07:56 EDT
arrr!

ya, we can easily fix this one for M7

Thanks for reporting it!
Comment 2 Curtis Windatt CLA 2008-04-23 15:54:42 EDT
Created attachment 97301 [details]
Patch

Unless I'm mistaken, the problem here is that the wizard page requires at least one selection, even though it is perfectly reasonable to have nothing selected.  This patch simply removes the requirement.

Note that this means that users can skip the page entirely by hitting the finish button on the previous page.
Comment 3 Chris Aniszczyk CLA 2008-04-24 04:35:23 EDT
>20080424

Thanks Curtis!

I also made it so the option to update references is off by default now... that shouldn't have been on by default in the first place.
Comment 4 Chris Aniszczyk CLA 2008-04-24 04:35:27 EDT
Created attachment 97393 [details]
mylyn/context/zip