Bug 227280 - PDEPlugin forces activation of DebugPlugin
Summary: PDEPlugin forces activation of DebugPlugin
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 RC1   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2008-04-16 04:07 EDT by Dani Megert CLA
Modified: 2015-07-28 09:28 EDT (History)
2 users (show)

See Also:
curtis.windatt.public: review? (caniszczyk)


Attachments
Fix (4.38 KB, patch)
2008-05-07 15:43 EDT, Curtis Windatt CLA
no flags Details | Diff
mylyn/context/zip (10.87 KB, application/octet-stream)
2008-05-07 15:43 EDT, Curtis Windatt CLA
no flags Details
org.eclipse.pde.ui.patch (4.52 KB, patch)
2008-05-07 19:56 EDT, Chris Aniszczyk CLA
no flags Details | Diff
mylyn/context/zip (694 bytes, application/octet-stream)
2008-05-07 19:56 EDT, Chris Aniszczyk CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2008-04-16 04:07:01 EDT
3.4 M6a but also 3.3.x.

Until 3.4 this bug was not important because Debug was always loaded when the menus got populated. This has been fixed in Platform UI during 3.4.

Now, the problem is that the PDEPlugin always loads the DebugPlugin because it attaches some listeners. All those listeners aren't needed until the Debug plug-in  is active. Hence the PDEPlugin should add a bundle listener and once it detects that Debug is activated, attach the listeners and remove the bundle listener.


FYI: the PDEPlugin is loaded when starting a fresh workspace because it registers the enabled ExternalPluginLibrariesFilter on the Package Explorer.
Comment 1 Dani Megert CLA 2008-04-16 04:07:47 EDT
Not really major but would be nice to get fixed as this would improve startup performance.
Comment 2 Chris Aniszczyk CLA 2008-04-16 09:33:25 EDT
I think it's major, anything to help :)
Comment 3 Chris Aniszczyk CLA 2008-04-28 09:38:55 EDT
Will do in RC1
Comment 4 Chris Aniszczyk CLA 2008-05-05 11:59:51 EDT
Curtis, since this has the word 'debug' in it, I will give it to you for investigation in RC1 :P
Comment 5 Curtis Windatt CLA 2008-05-07 15:43:33 EDT
Created attachment 99152 [details]
Fix

Checks if the debug plugin is started, if so, the config listener is added.  Otherwise, adds a bundle listener that adds the config listener after the plugin is started.
Comment 6 Curtis Windatt CLA 2008-05-07 15:43:36 EDT
Created attachment 99153 [details]
mylyn/context/zip
Comment 7 Curtis Windatt CLA 2008-05-07 15:44:56 EDT
Chris, please review the fix.  I wouldn't be surprised if there are better ways to check whether a bundle is installed, etc.
Comment 8 Chris Aniszczyk CLA 2008-05-07 19:56:03 EDT
Created attachment 99205 [details]
org.eclipse.pde.ui.patch

Cleaned up the code a bit.

Curtis, I'm so excited you're using contexts and Mylyn, I don't know what to do with myself anymore
Comment 9 Chris Aniszczyk CLA 2008-05-07 19:56:05 EDT
Created attachment 99206 [details]
mylyn/context/zip
Comment 10 Chris Aniszczyk CLA 2008-05-07 19:57:52 EDT
done.

> 20080507
Comment 11 Curtis Windatt CLA 2008-05-08 14:39:31 EDT
Thanks for the code improvement Chris, I knew there had to be an easier way to get the bundle I needed.

Verified.