Bug 227207 - [ftp] FTP should support canceling operations even if they are stuck
Summary: [ftp] FTP should support canceling operations even if they are stuck
Status: NEW
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 2.0.1   Edit
Hardware: PC Windows XP
: P2 enhancement (vote)
Target Milestone: ---   Edit
Assignee: dsdp.tm.rse-inbox CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: bugday, helpwanted
Depends on:
Blocks: 205261 219792
  Show dependency tree
 
Reported: 2008-04-15 15:16 EDT by Martin Oberhuber CLA
Modified: 2012-11-19 04:45 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2008-04-15 15:16:25 EDT
From Bug 205261 comment 5:

We're occasionally seeing the FTP upload or download getting stuck, see bug 205261 or bug 219792. Notwithstanding the need to get these issues fixed (supposedly in Apache Commons Net), the RSE FTP Service should be checking its Progress Monitor in a Thread separate from the Commons Net upload or download, such that it can interrupt or destroy the hanging Thread if necessary:

* Always spawn off a separate thread for upload or download, thereby also
  fixing bug 180965 to allow multiple parallel uploads/downloads (separate
  Thread would be a full FTP client of its own, including full Login
  procedure - at least for files > 20 K Bytes or so)

* In the thread that was called from the outside, just update progress monitor
  and check for monitor.isCanceled(); do all that outside the FTP command 
  mutex

* If canceled, kill the upload thread (thereby avoiding hanging thread due to
  network i/o which is not checking for cancel).
Comment 1 Martin Oberhuber CLA 2008-04-15 15:17:48 EDT
This is an important enhancement in an area that's currently blocking further widespread adoption of RSE. We should try getting it in for M7!
Comment 2 Martin Oberhuber CLA 2008-04-15 15:28:18 EDT
It's clear what to do and the work seems manageable ... isn't that an ideal BugDay candidate for some newcomers to get started!

Fire up Eclipse SDK, and import the Team Project Set from
http://www.eclipse.org/dsdp/tm/development/rse-anonymous.psf
The code to work on is all in FTPService.java and it should be fairly obvious what to do.

If you're interested, comment here on the bug or assign it to yourself, to avoid multiple people fixing the same thing at the same time. When done, Team > Create patch... and attach it here... you'll get into the TM Contributors Hall of Fame on  http://www.eclipse.org/dsdp/tm/development/contributors.php

If there are any questions, ask here on the bug or on http://wiki.eclipse.org/IRC
Comment 3 Martin Oberhuber CLA 2008-05-06 03:48:30 EDT
Javier will you have any chance to look at this?
Comment 4 Martin Oberhuber CLA 2008-05-20 18:06:05 EDT
Javier we desparately need this. Do you have any chance to get to it this week? I'd like to have it for RC2, which is Tuesday May 27.
Comment 5 Martin Oberhuber CLA 2008-09-16 12:39:55 EDT
Bulk update of target milestone
Comment 6 Martin Oberhuber CLA 2010-02-26 19:09:12 EST
Bulk update of target milestones to 3.2
Comment 7 Martin Oberhuber CLA 2011-05-31 17:47:49 EDT
Bulk moving 3.3 deferred items to 3.3.1