Bug 227105 - plugin.xml source editor should support content assist for identifiers
Summary: plugin.xml source editor should support content assist for identifiers
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.4 M7   Edit
Assignee: Benjamin Cabé CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-04-15 06:53 EDT by Markus Keller CLA
Modified: 2008-04-17 18:03 EDT (History)
2 users (show)

See Also:

Attachments
patch (6.35 KB, patch)
2008-04-17 17:33 EDT, Benjamin Cabé CLA 		no flags Details | Diff
mylyn/context/zip (994 bytes, application/octet-stream)
2008-04-17 17:33 EDT, Benjamin Cabé CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2008-04-15 06:53:57 EDT 
I20080410-1022

The plugin.xml source editor should support content assist for attributes that are of type 'identifier'. E.g. in ...

   <extension
         point="org.eclipse.ui.bindings">
        <key
                commandId="org.eclipse.ui.views.showView"
                schemeId="org.eclipse.ui.defaultAcceleratorConfiguration"
                sequence="M2+M3+Q T">
                <parameter
                        id="org.eclipse.ui.views.showView.viewId"
                        value="org.eclipse.jdt.ui.TypeHierarchy">
                </parameter>
        </key>

..., content assist should be available after 'commandId="', 'schemeId="', and 'parameter id="' and offer valid identifiers.
Comment 1 Benjamin Cabé CLA 2008-04-16 03:02:57 EDT 
Done :)
I'll attach the patch as soon as I'll have an Internet access on my PC again!
Comment 2 Benjamin Cabé CLA 2008-04-17 17:33:27 EDT 
Created attachment 96512 [details]
patch

Here it is. The proposals are displayed using the "identifier attribute icon".

NB: I've also changed the icon used when using content assist for boolean attributes...
Comment 3 Benjamin Cabé CLA 2008-04-17 17:33:45 EDT 
Created attachment 96513 [details]
mylyn/context/zip
Comment 4 Chris Aniszczyk CLA 2008-04-17 17:48:23 EDT 
I could hear the screams of joy coming from the IBM Zurich downtown office.

Thanks Ben!
Comment 5 Chris Aniszczyk CLA 2008-04-17 18:02:39 EDT 
looks good. I did notice we were getting description info boxes popping up which aren't valid in this case. We should disable that but I will let you do that in another bug :)
Comment 6 Chris Aniszczyk CLA 2008-04-17 18:03:00 EDT 
done.

> 20080417