Bug 227035 - PDE Launch Configuration Tabs does not have ID
Summary: PDE Launch Configuration Tabs does not have ID
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M7   Edit
Assignee: Darin Wright CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks: 227140
  Show dependency tree
 
Reported: 2008-04-14 17:15 EDT by Samantha Chan CLA
Modified: 2008-04-15 10:50 EDT (History)
2 users (show)

See Also:

Attachments
patch (5.06 KB, patch)
2008-04-14 22:34 EDT, Darin Wright CLA 		no flags Details | Diff
org.eclipse.pde.ui.patch (8.65 KB, patch)
2008-04-15 10:25 EDT, Chris Aniszczyk CLA 		no flags Details | Diff
mylyn/context/zip (1.04 KB, application/octet-stream)
2008-04-15 10:25 EDT, Chris Aniszczyk CLA 		no flags Details
mylyn/context/zip (1.13 KB, application/octet-stream)
2008-04-15 10:50 EDT, Chris Aniszczyk CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Samantha Chan CLA 2008-04-14 17:15:16 EDT 
The launch configuration tabs from org.eclipse.pde.ui all extend from AbstractLaunchConfigurationTab.  However, they do not override the #getID method.  This prevents clients from inserting tabs into PDE tab groups when a new tab is contributed via the org.eclipse.debug.ui.launchConfigurationTabs extension point.
Comment 1 Chris Aniszczyk CLA 2008-04-14 21:01:46 EDT 
Darin, what's your thoughts on this since this falls in the land of Debug.
Comment 2 Darin Wright CLA 2008-04-14 22:34:37 EDT 
Created attachment 96028 [details]
patch

I would do something like this.
Comment 3 Chris Aniszczyk CLA 2008-04-15 10:07:57 EDT 
Thanks!
Comment 4 Chris Aniszczyk CLA 2008-04-15 10:25:30 EDT 
Created attachment 96077 [details]
org.eclipse.pde.ui.patch

Thsi would require API changes so we can't do it now due to API freeze.

However, here is an improved patch for 3.5
Comment 5 Chris Aniszczyk CLA 2008-04-15 10:25:32 EDT 
Created attachment 96078 [details]
mylyn/context/zip
Comment 6 Chris Aniszczyk CLA 2008-04-15 10:26:09 EDT 
targetting 3.5
Comment 7 Darin Wright CLA 2008-04-15 10:41:31 EDT 
If you just use the strings rather than public constants, then there are technically no API changes (just implementing an inherited method). That way extensions could refer to the tabs. In 3.5, you could migrate to use the public constants. This would enable 3.4 tooling higher up the food chain to contribute extra tabs to the PDE launch configs.
Comment 8 Chris Aniszczyk CLA 2008-04-15 10:48:44 EDT 
fair enough, I'm OK with that compromise for now
Comment 9 Chris Aniszczyk CLA 2008-04-15 10:50:40 EDT 
done.

Samantha, what are you using PDE's launchers for :)? I'm always curious to see what people are up to.
Comment 10 Chris Aniszczyk CLA 2008-04-15 10:50:45 EDT 
Created attachment 96084 [details]
mylyn/context/zip