Bug 226933 - Generate Deployment Descriptor Stub on Deployment Descriptor Node
Summary: Generate Deployment Descriptor Stub on Deployment Descriptor Node
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.1 M4   Edit
Assignee: Dimitar Giormov CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard: EaseOfUse
Keywords: plan
Depends on: 226527 226583
Blocks:
  Show dependency tree
 
Reported: 2008-04-14 09:56 EDT by Dimitar Giormov CLA
Modified: 2009-02-04 09:13 EST (History)
2 users (show)

See Also:
cbridgha: review+

Attachments
enables generate deployment descriptor stub on deployment descriptor node for Java EE 5 projects (6.09 KB, patch)
2008-04-16 02:56 EDT, Dimitar Giormov CLA 		no flags Details | Diff
fixed wih chucks recomendations (10.18 KB, text/plain)
2008-12-11 03:44 EST, Dimitar Giormov CLA 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitar Giormov CLA 2008-04-14 09:56:25 EDT 
Build ID: I20080330-1350

Steps To Reproduce:
It will be really useful if Generate Deployment Descriptor Stub is present on the Deployment Descriptor Node. 
I think that this is natural place for the action.

One way is to have the Generate Deployment Descriptor Stub action available when there is no xml file, and to have open when there is a xml file.

Or to have the same behavior like in the context menu on project level (Java EE Tools menu).
Comment 1 Dimitar Giormov CLA 2008-04-16 02:56:16 EDT 
Created attachment 96201 [details]
enables generate deployment descriptor stub on deployment descriptor node for Java EE 5 projects
Comment 2 Kaloyan Raev CLA 2008-04-16 03:02:38 EDT 
Chuck, this could be considered as an UI change. I think, if review is OK, it should be also nominated for PMC review.
Comment 3 Chuck Bridgham CLA 2008-04-18 12:02:05 EDT 
Have you tried to use ProjectUtilities.getProject(Object)
rather than your getProjectFromSelection method?

You will notice that "IAdaptable" is a supported interface, and 
a call to ((IAdaptable) object).getAdapter(IProject.class) could return a project in the case of these Group nodes.

Its a little cleaner, and because this interface is supported, more actions can be used with these nodes.
Comment 4 Kaloyan Raev CLA 2008-05-12 04:09:15 EDT 
deferring for next release
Comment 5 Dimitar Giormov CLA 2008-12-11 03:44:47 EST 
Created attachment 120164 [details]
fixed wih chucks recomendations
Comment 6 Dimitar Giormov CLA 2008-12-11 04:01:17 EST 
committed and released.