Bug 226890 - [jsr199] enable CompilerToolTests#testCompilerOneClassWithEclipseCompiler4 on Linux
Summary: [jsr199] enable CompilerToolTests#testCompilerOneClassWithEclipseCompiler4 on...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.4   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.4 M7   Edit
Assignee: Maxime Daniel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-14 05:40 EDT by Maxime Daniel CLA
Modified: 2008-04-28 10:25 EDT (History)
3 users (show)

See Also:

Attachments
Suggested fix + test enablement (3.08 KB, patch)
2008-04-14 05:42 EDT, Maxime Daniel CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Daniel CLA 2008-04-14 05:40:56 EDT 
I20080330-1350

Due to http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6419926, JavaFileObject#toUri() happens to return non-absolute URIs on some systems, including Linux. First approach has been to avoid running those of our tests that were impacted by this behavior. After discussing with Jérôme, we decided that we'd better protect ourselves against the bug and run the test on all platforms.
Comment 1 Maxime Daniel CLA 2008-04-14 05:42:19 EDT 
Created attachment 95884 [details]
Suggested fix + test enablement
Comment 2 Maxime Daniel CLA 2008-04-14 07:29:33 EDT 
Released for 3.4 M7.
This is the suggested patch, less a few comment lines in the tests.
Kent, pls yell if needed.
Comment 3 Olivier Thomann CLA 2008-04-14 08:47:14 EDT 
I think if we want toUri() to always return an absolute URI with the file protocol, we should fix the implementation, not the callers.
Comment 4 Maxime Daniel CLA 2008-04-14 09:26:37 EDT 
The problem is that the defective implementation is not in our hands. Or do I miss something?
Comment 5 Olivier Thomann CLA 2008-04-14 09:30:47 EDT 
You are right. The test should be renamed. testCompilerOneClassWithEclipseCompiler4 is not a good name since we are using the file manager from the system compiler to feed our compiler.

So the patch seems to be fine.
Comment 6 David Audel CLA 2008-04-28 10:25:59 EDT 
Verified for 3.4M7 using I20080427-2000