Bug 226800 - one-line xml docs not parsed correctly
Summary: one-line xml docs not parsed correctly
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M7   Edit
Assignee: Jacek Pospychala CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks: 197666
  Show dependency tree
 
Reported: 2008-04-12 06:26 EDT by Jacek Pospychala CLA
Modified: 2008-04-12 07:41 EDT (History)
1 user (show)

See Also:

Attachments
screenshot (28.48 KB, image/gif)
2008-04-12 06:26 EDT, Jacek Pospychala CLA 		no flags Details
trace (3.55 KB, patch)
2008-04-12 06:28 EDT, Jacek Pospychala CLA 		no flags Details | Diff
testcase (1.17 KB, patch)
2008-04-12 06:29 EDT, Jacek Pospychala CLA 		no flags Details | Diff
proposed fix (1.19 KB, patch)
2008-04-12 06:31 EDT, Jacek Pospychala CLA 		no flags Details | Diff
mylyn/context/zip (849 bytes, application/octet-stream)
2008-04-12 07:41 EDT, Chris Aniszczyk CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jacek Pospychala CLA 2008-04-12 06:26:15 EDT 
Created attachment 95794 [details]
screenshot

it's spin-off of bug 197666.

One-line xml docs like plugin.xml or cheatsheet are not parsed correctly.

See my precious screenshot.
Comment 1 Jacek Pospychala CLA 2008-04-12 06:28:31 EDT 
Created attachment 95795 [details]
trace

trace of BadLocationException causing the problem
Comment 2 Jacek Pospychala CLA 2008-04-12 06:29:03 EDT 
Created attachment 95796 [details]
testcase

testcase
Comment 3 Jacek Pospychala CLA 2008-04-12 06:31:17 EDT 
Created attachment 95797 [details]
proposed fix

proposed fix - fixes attached testcase and don't cause any new tests fails. fixes also cheatsheet testcases (https://bugs.eclipse.org/bugs/show_bug.cgi?id=197666#c9)
Comment 4 Chris Aniszczyk CLA 2008-04-12 07:40:56 EDT 
Thanks Jacek.

Looks good.

> 20080412
Comment 5 Chris Aniszczyk CLA 2008-04-12 07:41:00 EDT 
Created attachment 95800 [details]
mylyn/context/zip