Community
Participate
Working Groups
Created attachment 95759 [details] Plugins for RSE Terminal Integration +++ This bug was initially created as a clone of Bug #170910 +++ Based on the new Terminal APIs from bug 170910, MontaVista's contribution of an initial RSE Terminal Integration should be added as a separate RSE Feature in Incubation to start with. Attached is the current contribution which builds against RSE 3.0M6 candidate. It's still got several problems, such as * On disconnect, "connected" status is not revoked * Terminal Encodings should be set (pending bug 204796) * "Launch Terminal" action in file subsystem should be contributed declaratively (this is bug 226550) * Contribution should be re-written such that it can take an existing RSE IShellService and ask for getAdapter(ITerminalService) in a generic way. This would help such that only ONE subsysteConfiguration is needed that can run against ANY IShellServiceSubsystem. Problem with that approach, though, might be that the "Remote Command" subsystem cannot be hidden and entirely replaced by Terminal Subsystem in that case * In the case where ONLY Terminal subsystem exists but NO shell subsystem, adaptable mechanism should be used in order to still provide access to the "Linux Shell Processes Subsystem" which requires an IHostShell Original contribution was submitted with legal message as per bug 170910 comment 17: We, Anna Dushistova,Yu-Fen Kuo and Eugeniy Melekhov, declare that we developed attached code from scratch, without referencing any 3rd party materials except material licensed under the EPL. We are authorized by our employer to make this contribution under the EPL.
I submitted the contribution on IPZilla for Legal Review: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=2256
The contribution was approved, and I checked in the three plugins under /cvsroot/dsdp , org.eclipse.tm.rse/plugins/ I'm keeping this bug open in order to add the also required changes for Release Engineering, such as defining a feature, modifying the team project set, and adding it to the Downloads page. I'd also like to see more contributions for fixing some of the urgent issues with the current code. We'll see if we keep everything on this bug or split it up into separate bug reports as needed.
I'm wondering what code in this contribution specifically comes from Eugeniy Melekhov. He is not mentioned in any of the Copyright Headers. Do I need to add him to the list of contributors for DSDP-TM?
Martin, Eugeniy participated in API discussions and new API creation only.
Is the expected behaviour on disconnect the same as for shells subsystem?
Unless you can propose something else, I'd say yes?
The Terminal Subsystem has been checked in, and added to releng such that it's available as a download as well as on the update site: http://download.eclipse.org/dsdp/tm/downloads/drops/I20080417-0800/index.php I'm marking this bug fixed, we'll track the remaining issues in separate bugs, all of which are available from the bugzilla "blocks" field for now.
