Bug 226592 - Properties view of a server is missing a title name
Summary: Properties view of a server is missing a title name
Status: CLOSED FIXED
Alias: None
Product: WTP ServerTools
Classification: WebTools
Component: wst.server (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 M7   Edit
Assignee: Tim deBoer CLA
QA Contact: Tim deBoer CLA
URL:
Whiteboard: PMC
Keywords: ui
Depends on:
Blocks:
 
Reported: 2008-04-10 16:09 EDT by Larina Cheung CLA
Modified: 2017-10-11 16:22 EDT (History)
4 users (show)

See Also:
arvera: pmc_approved? (david_williams)
raghunathan.srinivasan: pmc_approved+
arvera: pmc_approved? (naci.dai)
arvera: pmc_approved? (deboer)
arvera: pmc_approved? (neil.hauge)
kaloyan: pmc_approved+

Attachments
Screen capture of the Properties window. (1.51 MB, image/bmp)
2008-04-10 16:10 EDT, Larina Cheung CLA 		no flags Details
v1 (3.57 KB, patch)
2008-04-10 19:03 EDT, Angel Vera CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Larina Cheung CLA 2008-04-10 16:09:49 EDT 
Build ID: 3.4.0.v20080324a

Steps To Reproduce:
1.In the Servers view, right-click a server and select Properties.
2.The Properties window opens.
3.The title is "Properties for".
4.The dialog is missing the server name, such as "Properties for Tomcat v6.0 server"


More information:
Comment 1 Larina Cheung CLA 2008-04-10 16:10:49 EDT 
Created attachment 95584 [details]
Screen capture of the Properties window.
Comment 2 Angel Vera CLA 2008-04-10 16:17:23 EDT 
Thanks for catching this one. 

It should be a quick fix, but it needs PMC approval.
Comment 3 Angel Vera CLA 2008-04-10 19:03:59 EDT 
Created attachment 95608 [details]
v1 

This will fix the problem. But I want to see if I can provide a solution without implementing IWorkbenchAdapter, maybe by extending WorkbenchLabelProvider
Comment 4 Angel Vera CLA 2008-04-11 10:50:04 EDT 
It seems that the right approach is to use IWorkbenchAdapter. So I my proposed patch is still valid.
Comment 5 Angel Vera CLA 2008-04-11 11:09:38 EDT 
Sending for PMC approval. 

PMC-Members:
This is a simple UI fix with low risk of breaking other code, but it is important to put the changes in as the sentence at the top of the dialog is incomplete.
Comment 6 Tim deBoer CLA 2008-04-16 12:36:44 EDT 
Patch released for Angel.
Comment 7 Tim deBoer CLA 2008-06-26 14:32:42 EDT 
Verified, closing.
Comment 8 Eclipse Genie CLA 2017-10-11 16:22:52 EDT 
New Gerrit change created: https://git.eclipse.org/r/108600