Community
Participate
Working Groups
+++ This bug was initially created as a clone of Bug #226301 +++ Just like with the RemoteFileException class hierarchy, we need more generic children of SystemMessageException for cancellation, network I/O error and security error. I propose generalizing RemoteFileException by adding another base class above it, in org.eclipse.rse.services. That base class should deal with nested root exceptions just like RemoteFileException now. One possible name could be SystemRemoteMessageException Then we also need exceptions with concrete well-known messages: SystemRemoteCanceledException SystemRemoteSecurityException SystemRemoteIOException all declared in rse.services, for general usage in IShellService and others. handle it.
Tentatively assigning M6 since this is a simple enhancement but I'm not sure if I can make it.
As per bug 221211 comment 31, we'll need a new kind of SystemMessageException also for the case where a timeout occurs trying to acquire a remote channel or a lock on remote resources.
I'm not sure if I'll get a chance to look at this this week since I'm pretty busy with other stuff. You may want to assign this to someone else if you need it right away.
API Added in org.eclipse.rse.services/clientserver: [226374] [api] Need default SystemMessageException specialisations New API Classes in clientserver.messages: ----------------------------------------- SystemOperationCancelledException SystemUnsupportedOperationException SystemRemoteMessageException SystemNetworkIOException SystemOperationFailedException SystemRemoteSecurityException Deprecated API Classes in rse.services.files: --------------------------------------------- RemoteFileCancelledException -- Use SystemOperationCancelledException RemoteFileSecurityException -- Use SystemRemoteSecurityException Other API Changes: ------------------ RemoteFileException now extends SystemRemoteMessageException RemoteFileCancelledException now extends SystemOperationCancelledException New PII Strings Added (CommonMessages.properties): -------------------------------------------------- MSG_COMM_NETWORK_ERROR=Operation failed due to network I/O error ''{0}'' MSG_OPERATION_UNSUPPORTED = Operation not supported: ''{0}'' MSG_OPERATION_SECURITY_VIOLATION=Operation failed. Security violation on ''{0}'' New SystemMessageIDs added (ICommonMessageIds.java): ---------------------------------------------------- public static final String MSG_OPERATION_UNSUPPORTED = "RSEG9999"; public static final String MSG_OPERATION_SECURITY_VIOLATION = "RSEG9999"; public static final String MSG_COMM_NETWORK_ERROR = "RSEC9999"; The new message ID's need to be reviewed, properly assigned, and added to the relevant places e.g. systemmessages.xml, uiMessagesCore.html and probably ISystemMessages.java
Also added SystemUnexpectedErrorException
Also added new API: ------------------- SystemLockTimeoutException Along with new PII: ------------------- MSG_LOCK_TIMEOUT=A timeout occurred while trying to acquire a shared resource. As well as new Message ID (To be reviewed): ------------------------------------------- public static final String MSG_LOCK_TIMEOUT = "RSEG9999";
Added SystemElementNotFoundException Added PII: MSG_ELEMENT_NOT_FOUND = Missing element for {0}: \''{1}\'' Added ICommonMessageId: String MSG_ELEMENT_NOT_FOUND = "RSEG9999";//FIXME //$NON-NLS-1$
