Bug 226365 - [api][breaking] SystemPromptDialog should not implement IDialogConstants
Summary: [api][breaking] SystemPromptDialog should not implement IDialogConstants
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 2.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.0 M6   Edit
Assignee: Martin Oberhuber CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: api
Depends on: 180562
Blocks:
  Show dependency tree
 
Reported: 2008-04-09 16:40 EDT by Martin Oberhuber CLA
Modified: 2008-04-09 16:42 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2008-04-09 16:40:14 EDT 
In bug 180562 we decided that classes should not implement interface just in order to bring constants into their namespace.

Because of this, SystemPromptDialog should not implement IDialogConstants.

This is a breaking API change since after no longer implementing the interfaces, constants from IDialogConstants are no longer available to clients extending 
SystemPromptDialog, or one of its children.

MigrationDocs:
--------------
If you see compile errors in a class extending SystemPromptDialog directly or indirectly, prefix access to constants with IDialogConstants.
Comment 1 Martin Oberhuber CLA 2008-04-09 16:42:51 EDT 
Fix committed:
[226365][api][breaking] SystemPromptDialog should not implement IDialogConstants

Also removing deprecated void pack() from SystemPromptDialog, which did not do anything and wasn't called anywhere anyways.