Bug 226149 - Refactor templates for ConstraintProvider and ValidationProvider
Summary: Refactor templates for ConstraintProvider and ValidationProvider
Status: ASSIGNED
Alias: None
Product: GMF-Tooling (ARCHIVED)
Classification: Modeling
Component: Core (show other bugs)
Version: 2.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Artem Tikhomirov CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-04-08 12:27 EDT by Artem Tikhomirov CLA
Modified: 2010-07-19 12:19 EDT (History)
2 users (show)

See Also:


Attachments
Maybe you could find helpful these migration changes to support provided refactoring (14.32 KB, patch)
2008-04-14 12:59 EDT, Anna Karjakina CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Artem Tikhomirov CLA 2008-04-08 12:27:49 EDT
0. Adopt new template structure (move implementation templates under impl/, public out of xpt/)
1. Move extensions from ConstraintProvider.xpt to more general location (extensions.xpt)
2. Try to avoid IClientSelector unless inevitable (in favor of enablement tag)
3. Find out why isInDefaultEditorContext returns true for any object that is not View
4. Uses of semanticCtxIdMap look suspicious, need better approach
5. Need to check release build if schema doc for org.eclipse.emf.validation.constraintBindings fixed in respect to qualified class name of IClientSelector (which is not internal right now, though spec says it is)


More to follow, I suppose
Comment 1 Artem Tikhomirov CLA 2008-04-14 04:43:55 EDT
Delivered refactoring with explicit context entity (GenAuditContext) in the GMFGen model (to avoid by-context-id grouping), sematicCtxIdMap (4) gone in favour of explicit visualID check.

Lite runtime should reuse most of the stuff generated in full runtime - looks like there's not too much difference, except for few subtleties that might be handled with better structuring of the templates.
Comment 2 Anna Karjakina CLA 2008-04-14 12:59:01 EDT
Created attachment 95944 [details]
Maybe you could find helpful these migration changes to support provided refactoring
Comment 3 Artem Tikhomirov CLA 2008-04-18 09:13:17 EDT
(In reply to comment #2)
Migration was delivered into CVS.
Comment 4 Artem Tikhomirov CLA 2008-04-30 17:10:38 EDT
(In reply to comment #0)
While working on bug #228913, item 4, ValidationProvider was significantly refactored to inject java placeholders right into validate() method of appropriate AbstractModelConstraint.
Comment 5 Artem Tikhomirov CLA 2008-12-11 13:40:13 EST
ValidationAction is no longer contributed through ContributionItemProvider, regular jface's IEditorActionBarContributor does that, instead.
Comment 6 Eclipse Webmaster CLA 2010-07-19 12:19:10 EDT
[GMF Restructure] Bug 319140 : product GMF and component
Templates was the original product and component for this bug