Bug 225980 - feature.jar's generated from update site need update descriptor?
Summary: feature.jar's generated from update site need update descriptor?
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.4   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 3.4 M7   Edit
Assignee: Simon Kaegi CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-04-07 11:22 EDT by Timothy Webb CLA
Modified: 2008-04-07 12:13 EDT (History)
2 users (show)

See Also:


Attachments
patch to add update descriptor for feature.jar IUs (1.23 KB, patch)
2008-04-07 11:22 EDT, Timothy Webb CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Webb CLA 2008-04-07 11:22:30 EDT
Created attachment 95066 [details]
patch to add update descriptor for feature.jar IUs

Currently, when you generate metadata for an site.xml-style update site, the group as well as all IUs have associated update descriptors generated for them.  Is it intentional that the feature.jar that is generated from MetadataGeneratorHelper.createFeatureJarIU() does not set the update descriptor?  

When doing an update flow using site.xml style update sites, by not having the update descriptor, the jar is considered as a remove and add operation as opposed to an update which looks a bit odd when presented to the user, and causes a slightly different code path when performing the update.  The code in OperationGenerator.generateUpdates() will not consider anything an update that does not have an update descriptor.  While the provisioning still appears to do the right thing, the right fix seems to be including the update descriptor.

Attached is a patch that configures the update descriptor for the metadata generator.
Comment 1 Pascal Rapicault CLA 2008-04-07 12:13:38 EDT
Patch released in HEAD.