Bug 225510 - [api][breaking] RSE ServiceCommandShell leaks non-API OutputRefreshJob
Summary: [api][breaking] RSE ServiceCommandShell leaks non-API OutputRefreshJob
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.0 M6   Edit
Assignee: Martin Oberhuber CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2008-04-03 05:39 EDT by Martin Oberhuber CLA
Modified: 2008-04-03 05:47 EDT (History)
0 users

See Also:

Attachments
Patch fixing the issue (30.97 KB, patch)
2008-04-03 05:47 EDT, Martin Oberhuber CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2008-04-03 05:39:23 EDT 
ServiceCommandShell leaks protected non-API OutputRefreshJob field.
Comment 1 Martin Oberhuber CLA 2008-04-03 05:47:02 EDT 
Created attachment 94684 [details]
Patch fixing the issue

Attached patch fixes the issue. Strictly speaking, this is a compatible API change because clients wouldn't have been allowed to use the non-API OutputRefreshJob before the change:

* Made ServiceCommandShell#_lastRefreshJob field private
* Added ServiceCommandShell#notifyOutputChanged(IRemoteOutput[], boolean)

Extenders now call protected notifyOutputChanged() in order to notify outputs, instead of manipulating the private _lastRefreshJob directly.
Comment 2 Martin Oberhuber CLA 2008-04-03 05:47:24 EDT 
Patch committed:
[225510][api] Fix OutputRefreshJob API leakage