Bug 225437 - Layout improvements
Summary: Layout improvements
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows XP
: P3 enhancement
Target Milestone: 2.1   Edit
Assignee: Alex Boyko CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-02 17:38 EDT by Alex Boyko CLA
Modified: 2010-07-19 12:28 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Boyko CLA 2008-04-02 17:38:52 EDT
We need to be able to have distinct end points for edges. Draw2D graph layout algorithms produce the same start and end points for incoming/outgoing edges.

Draw2D graph layout also modified nodes sizes, so we need to solve this in GMF for now and possibly move the solution to Draw2D if it's successful.

Also, some basic support for laying out border items is needed at the graph layout  step.
Comment 1 Alex Boyko CLA 2008-04-03 13:04:28 EDT
Fixes committed to HEAD:

We have a new GMFDirectedGraphLayout that lays out the graph with the following improvements:
1) Doesn't modify nodes sizes
2) Routes edges around nodes with different sizes
3) Accounts for edges routing style (oblique or orthogonal)
4) Pads edges end points such that edges have distinct end points
5) Provides the support to lay out border nodes (border items)

ConstantSizeNode is to be used instead of Node to be able to preserve size of the node and supply border nodes to the parent node and to provide padding between edges end points.

ConstrainedEdge is to be used instead of Edge if routing style needs to be specified and if one of the edge's ends is a border node that need to be laid out.

ConstantSizeNode and ConstrainedEdge can be used with Draw2D DirectedGraphLayout just all the improvements will be gone. Equally, Draw2D Node and Edge can be used with GMFDirectedGraphLayout the improvements won't be there obviously.

Examples of GMFDirectedGraphLayout are presented in org.eclipse.gmf.examples.runtime.diagram.layout plugin (similarly to Draw2D graph layout examples). Therefore, any issues found with GMFDirectedGraphLayout need to come with a patch for the examples with the example where the problem is demonstrated.
Comment 2 Richard Gronback CLA 2008-08-13 13:09:14 EDT
[target cleanup] 2.1 M6 was the original target milestone for this bug
Comment 3 Eclipse Webmaster CLA 2010-07-19 12:28:35 EDT
[GMF Restructure] Bug 319140 : product GMF and component
Runtime Diagram was the original product and component for this bug