Bug 225320 - [4x][br][security] Adopt Equinox Secure Storage for RSE Passwords
Summary: [4x][br][security] Adopt Equinox Secure Storage for RSE Passwords
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P2 major (vote)
Target Milestone: 3.4 M6   Edit
Assignee: David Dykstal CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: helpwanted, investigate
Depends on:
Blocks: 370237
  Show dependency tree
 
Reported: 2008-04-02 08:40 EDT by Martin Oberhuber CLA
Modified: 2012-05-07 16:54 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2008-04-02 08:40:32 EDT
With Eclipse 3.4M6 comes the new Equinox Secure Storage component:
http://download.eclipse.org/eclipse/downloads/drops/S-3.4M6-200803301350/eclipse-news-M6.html#equinox.security.storage

We should adopt this for RSE Password Persistence, instead of the current Eclipse Keyring.

The fix should be relatively simple since only org.eclipse.rse.core /  PasswordPersistenceManager class should need to get modified.
Comment 1 Oleg Besedin CLA 2008-04-02 16:52:33 EDT
The similar request for CVS: bug 222124
The similar request for core.net: 214796

Both of those include "draft" patches. I'll try to provide similar "draft" patch for RSE, but it will probably be a few days to couple weeks before I can get to it.

Where can I find RSE source code?
Comment 2 Martin Oberhuber CLA 2008-04-02 17:35:11 EDT
Thanks Oleg. For RSE, best use the rse-anonymous.psf project set from http://www.eclipse.org/dsdp/tm/development/cvs_setup.php
Comment 3 Martin Oberhuber CLA 2008-05-07 05:10:29 EDT
It's unlikely we'll get to this in the 3.0 time frame, but I'm giving it another chance for RC1.
Comment 4 Martin Oberhuber CLA 2008-05-20 18:17:05 EDT
Dave do you think this is realistic in 3.0 ? - For CVS it seems to work smoothly now, so the migration should not be overly difficult...
Comment 5 David Dykstal CLA 2008-05-29 17:25:41 EDT
Moving enhancements to the 3.1 release.
Comment 7 Martin Oberhuber CLA 2012-01-31 12:16:48 EST
Looks like we'll need to do this in 3.4 / Juno since Eclipse 4.x doesn't ship the old 2.x style API's for passwords any more.

See also bug 370237 , bug 336129 .
Comment 8 David Dykstal CLA 2012-01-31 13:36:04 EST
(In reply to comment #7)
> Looks like we'll need to do this in 3.4 / Juno since Eclipse 4.x doesn't ship
> the old 2.x style API's for passwords any more.
> 
> See also bug 370237 , bug 336129 .

This should not be too tough. I was initially worried about migrating existing password stores but I think that is not practical and we should start fresh.
Comment 9 Martin Oberhuber CLA 2012-02-01 05:51:11 EST
That sounds great!

At any rate, we should make sure to document the change - maybe along with documenting the physical location of the old password store on disk as well as the new one, such that users can delete the old (unsafe) password store.

Another option might be keeping the old code for _reading_ the old store around such that users who must migrate some passwords can deploy the *.auth bundle (actually I guess that on top of 3.8 the old code should still work out of the box). So to me it looks like migration should be easy if we want to support it.

I'm setting target milestone 3.4M6 then (the next one) since that's typically the feature freeze milestone and we're talking about a significant feature change here.

Thanks,
Martin
Comment 10 David Dykstal CLA 2012-03-17 15:45:15 EDT
I will be integrating this change to the PasswordPersistenceManager for M6. Documentation and migration will still need to be tested but the function for saving passwords will be there and will function identically to previous releases.

There is no API change in PasswordPersistenceManager, but there is a dependency added to org.eclipse.rse.core for the new secure storage API. The plugin versions will be updated as a result.
Comment 11 David Dykstal CLA 2012-03-18 15:10:39 EDT
Adding JUnits for PasswordTestSuite to our build suite as well.
Comment 12 David Dykstal CLA 2012-03-24 13:17:19 EDT
Migration testing complete. New JUnit testcases added.

Resolving as fixed.