Bug 225162 - Bugs with new pinnable palette stacks
Summary: Bugs with new pinnable palette stacks
Status: RESOLVED FIXED
Alias: None
Product: GEF
Classification: Tools
Component: GEF-Legacy GEF (MVC) (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P2 major (vote)
Target Milestone: 3.4.0 (Ganymede) M7   Edit
Assignee: Cherie Revells CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility, contributed
Depends on:
Blocks:
 
Reported: 2008-04-01 13:35 EDT by Cherie Revells CLA
Modified: 2008-09-18 13:39 EDT (History)
1 user (show)

See Also:

Attachments
Bug fixes (32.45 KB, patch)
2008-04-04 11:17 EDT, Cherie Revells CLA 		ahunter.eclipse: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cherie Revells CLA 2008-04-01 13:35:38 EDT 
- keyboard accessibility does not work with pinnable stacks
- pin figure needs to be centered a bit better
- the outline of the stack figure has a funny line bend when expanding last or
first stack in row -- noticable most in columns layout mode.
Comment 1 Cherie Revells CLA 2008-04-04 11:17:29 EDT 
Created attachment 94865 [details]
Bug fixes

Fixes for the following issues:
- Fixed keyboard accessibility for palette stacks by making changes to PaletteViewerKeyHandler.
- Modified the PinDrawerAction to work on all pinnable palette editparts including stacks (allowing keyboard accessibility for pinning stacks).
- Moved pin slightly to the left so it lines up with the drawer's pin.
- Fixed funny line bend when expanding last or first stack in row (in columns and icons layout mode).
- The active tool title in a stack no longer shows behind the pin.

Anthony, this one is ready for review.  I added a new public interface:  IPinnableEditPart.  If it is not ok to add this interface at this point, I can rework the code a bit.
Comment 2 Anthony Hunter CLA 2008-04-07 16:42:27 EDT 
Committed to HEAD