Bug 224815 - Make Detail formatters exportable
Summary: Make Detail formatters exportable
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.4   Edit
Hardware: PC All
: P3 enhancement (vote)
Target Milestone: 3.8 M5   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, contributed, noteworthy
Depends on:
Blocks:
 
Reported: 2008-03-30 18:33 EDT by Benjamin Muskalla CLA
Modified: 2012-01-26 14:33 EST (History)
3 users (show)

See Also:


Attachments
Patch to jdt.debug.ui to add preference transfer for detail_formatters (2.06 KB, patch)
2012-01-10 14:04 EST, Brian de Alwis CLA
Michael_Rennie: iplog+
Michael_Rennie: review+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Muskalla CLA 2008-03-30 18:33:55 EDT
It would be really great to have the ability to export/import detail formatters as well as logical structures. I think this would help to spread these things over a team in a softer way then bug 75428.

I think this could be a nice thing for a Bug Day.
Comment 1 Brian de Alwis CLA 2012-01-10 14:04:08 EST
Created attachment 209281 [details]
Patch to jdt.debug.ui to add preference transfer for detail_formatters

The detail formatters aren't available for import as we're missing a preference transfer for the corresponding entry.
Comment 2 Michael Rennie CLA 2012-01-10 14:55:55 EST
(In reply to comment #1)
> Created attachment 209281 [details]
> Patch to jdt.debug.ui to add preference transfer for detail formatters

Very cool! Are you planning on working on the importer as well?

I tested the patch and the export is working nicely.
Comment 3 Brian de Alwis CLA 2012-01-10 15:18:56 EST
(In reply to comment #2)
> Very cool! Are you planning on working on the importer as well?

Hmm, from what I understood, the exporter has always worked.  At least my .epf files (created long before this patch) have an item for "/instance/org.eclipse.jdt.debug.ui/org.eclipse.jdt.debug.ui.detail_formatters".  With my change, I can now *import* the detail formatters from this .epf file and they show up in my preferences.
Comment 4 Michael Rennie CLA 2012-01-10 17:00:12 EST
(In reply to comment #3)
> (In reply to comment #2)
> > Very cool! Are you planning on working on the importer as well?
> 
> Hmm, from what I understood, the exporter has always worked.  At least my .epf
> files (created long before this patch) have an item for
> "/instance/org.eclipse.jdt.debug.ui/org.eclipse.jdt.debug.ui.detail_formatters".

You are correct - the gotcha is that if you do not have the 'Export All' option checked, you do not get them. The transfer extension gives you the ability to select the group 'Detail formatters' when exporting.

>  With my change, I can now *import* the detail formatters from this .epf file
> and they show up in my preferences.

This also worked before, as long as you had the 'Import all' option selected. I see that with your patch we have the option to import just detail formatters.

I also noticed that our transfer group for logical structures is not showing up.
Comment 5 Michael Rennie CLA 2012-01-10 17:03:11 EST
(In reply to comment #4)
 
> I also noticed that our transfer group for logical structures is not showing
> up.

That would be because I don't have any custom logical structures to export. Once I added some it shows up as expected.
Comment 6 Michael Rennie CLA 2012-01-10 17:29:52 EST
Pushed the patch to master with a minor edit to update the date in the messages file: http://git.eclipse.org/c/jdt/eclipse.jdt.debug.git/commit/?id=fb2b6facfe43adfdf11e2182ad7d1f0a4e460335

I also updated the test script with a new blurb about import/export: http://wiki.eclipse.org/Debug/Test_Script#Detail_Formatters

Thanks for the patch Brian!
Comment 7 Michael Rennie CLA 2012-01-26 14:33:02 EST
verified in I20120125-1800