Bug 224618 - Filter does not work for special characters
Summary: Filter does not work for special characters
Status: CLOSED FIXED
Alias: None
Product: Data Tools
Classification: Tools
Component: Connectivity (show other bugs)
Version: 1.6   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 1.6M7(RC0)   Edit
Assignee: Brian Fitzpatrick CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-03-28 10:05 EDT by Enrico Schenk CLA
Modified: 2008-07-01 17:43 EDT (History)
1 user (show)

See Also:

Attachments
Patch suggestion (1.91 KB, patch)
2008-03-28 10:05 EDT, Enrico Schenk CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrico Schenk CLA 2008-03-28 10:05:14 EDT 
Created attachment 93972 [details]
Patch suggestion

Build ID: 3.3.1.1 M20071023-1652

Steps To Reproduce:
1. Create a table (e.g. in a derby profile) starting with a $ (CREATE TABLE "$newtable" (col integer))
2. Apply a "Starts with" filter with the expression "$"
3. The table $newtable is not shown in the table list


More information:
DTP: dtp-sdk-1.6M6-200803270500

The filter uses a regular expression to filter the database objects (ConnectionFilterImpl.NotLikeFilter). The regex pattern is based on the filter expression, but the filter expression is not escaped, so that special characters can lead to an unexpected result.
Comment 1 Brian Fitzpatrick CLA 2008-03-28 10:11:04 EDT 
This looks like a great fix. I'll try and get it delivered on Monday next week (we're working through a build issue with the M6 milestone build and I don't want to deliver anything until we get that resolved).

Thanks Rico!
Comment 2 Brian Fitzpatrick CLA 2008-04-07 17:07:33 EDT 
Delivered fix today. Should appear in a build in a couple of days. Thanks Rico!
Comment 3 Brian Fitzpatrick CLA 2008-07-01 17:43:19 EDT 
Closing bugs