Bug 224613 - Quick fix to remove empty plugin.xml should remove it from build.properties
Summary: Quick fix to remove empty plugin.xml should remove it from build.properties
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.5 M5   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2008-03-28 09:57 EDT by Ed Merks CLA
Modified: 2008-12-23 15:48 EST (History)
4 users (show)

See Also:

Attachments
Patch to delete the plugin.xml entry from build.properties (2.24 KB, patch)
2008-12-19 11:45 EST, Ankur Sharma CLA 		curtis.windatt.public: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Merks CLA 2008-03-28 09:57:25 EDT 
Since we're effectively being forced to remove empty plugin.xml and the quick fix is the simple way to do it, it seems best that we don't end up with the inevitable warning that the plugin.xml mentioned in the build.properties needs to be deleted too.  The quick fix could do both things.
Comment 1 Chris Aniszczyk CLA 2008-03-28 10:03:41 EDT 
tagging for bugday
Comment 2 Benjamin Cabé CLA 2008-03-28 12:31:40 EDT 
I'll take care of this one, Chris :) (as soon as I'll be back from my California trip :op)
Comment 3 Chris Aniszczyk CLA 2008-04-09 00:20:04 EDT 
You need to tell me all about California and how it went for you :)

Did you go to San Francisco? Napa valley? where :)?
Comment 4 Ankur Sharma CLA 2008-12-19 11:45:59 EST 
Created attachment 120963 [details]
Patch to delete the plugin.xml entry from build.properties

The fix deletes the plugin.xml entry from the build.properties once its(plugin.xml) is deleted.

Class : org.eclipse.pde.internal.ui.correction.DeletePluginBaseResolution
Methos : run
Comment 5 Curtis Windatt CLA 2008-12-19 15:45:40 EST 
Works great, applied patch to HEAD.  Congrats on your first PDE UI contribution Ankur.
Comment 6 Chris Aniszczyk CLA 2008-12-23 15:47:50 EST 
reopening to assign to Curtis
Comment 7 Chris Aniszczyk CLA 2008-12-23 15:48:35 EST 
Thanks Curtis and Ankur!