Bug 224488 - Severe regression in EMF-to-XML translators since 3.0M5
Summary: Severe regression in EMF-to-XML translators since 3.0M5
Status: CLOSED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 blocker (vote)
Target Milestone: 3.0 M6   Edit
Assignee: Jason Peterson CLA
QA Contact:
URL:
Whiteboard: Review
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-03-27 18:54 EDT by Cameron Bateman CLA
Modified: 2008-05-01 14:00 EDT (History)
3 users (show)

See Also:
cbridgha: review+


Attachments
patch (1.02 KB, patch)
2008-04-02 13:18 EDT, Jason Peterson CLA
bjorn.freeman-benson: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron Bateman CLA 2008-03-27 18:54:27 EDT
A problem is manifesting at HEAD that did not exist in M5.  To reproduce:

Open the faces-config editor on a JSF project.
Add a managed bean.
Switch to source and note it was added correctly.
Now, remove the whole managed XML entry using the source editor.
Switch back, EMF model hasn't been updated to reflect changes.
EMF is now (and seemlingly permanently until restart) out of sync with the source file.  Trying to edit through visual editor throws an exception.
Comment 1 Cameron Bateman CLA 2008-03-27 20:21:50 EDT
Further narrowing the time frame:

Problem doesn't reproduce in 2.x stream.
Problem doesn't reproduce in M5 build

HOWEVER, when I revert our plugins to v20080205 (slightly before M5) but use the driver (Eclipse/WTP) I20080321174820, the problem does reproduce.

So it appears that the problem is traceable to some change below JSF in WTP between 3.0M5 and the present.
Comment 2 Gerry Kessler CLA 2008-03-28 17:10:19 EDT
Chuck,  I am reassigning this bug to you.

I have traced the problem to the fix for Bug#221793.   When I revert your change, this regression is no longer.

Comment 3 Raghunathan Srinivasan CLA 2008-04-01 18:25:57 EDT
Any update on this issue?
Comment 4 Chuck Bridgham CLA 2008-04-01 20:42:30 EDT
Jason can you take a look at this scenario?  Need to understand how your change affected them.
Comment 5 Jason Peterson CLA 2008-04-02 13:18:37 EDT
Created attachment 94581 [details]
patch
Comment 6 Jason Peterson CLA 2008-04-02 13:21:09 EDT
Backing out changes made from 221793.  This fix has caused regression issues.
The issues it had resolved are now fixed by bug # 225196.
Comment 7 Chuck Bridgham CLA 2008-04-03 13:13:54 EDT
We missed this one....   It is reverting changes that caused this regression, and with the proper fix for https://bugs.eclipse.org/bugs/show_bug.cgi?id=225196,
All related scenarios are fixed.

This fix is safe, and because it is affecting other components, would recommend we include this into M6 driver.
Comment 8 Chuck Bridgham CLA 2008-04-03 13:14:13 EDT
Approved review
Comment 9 Carl Anderson CLA 2008-04-03 14:17:31 EDT
Chuck committed this to HEAD.
Comment 10 Cameron Bateman CLA 2008-04-07 18:09:42 EDT
Verified in 3.0M6.
Comment 11 David Williams CLA 2008-04-24 00:43:31 EDT
mass change to add 'contributed' keyword based on bugzilla query, please correct if that's not accurate (by marking patches as obsolete and removing the 'contributed' keyword. 
Comment 12 Carl Anderson CLA 2008-05-01 14:00:17 EDT
Closing fixed bugs.