Community
Participate
Working Groups
1. Integer overflow avoiding fix to distance between two points 2. Integer overflow avoiding fix for Geomtery#linesIntersect(...) 3. Moved left and right node references from virtual node to node and added punblic getters to access left and right nodes from the client layer. All nodes have references to left and right side nodes intialized in PopulateRanks graph visitor and not only virtual nodes. This change is important for graph layout post processing procedures such as alternative edge routing. 4. TransposeMetrics graph visitor should transpose virtual node dimensions. 5. PrecisionRectangle#setSize(Dimension d) is added to handle PrecisionDimension Patch will be attached
Created attachment 93877 [details] patch Fixes for the described issues
Hi Alex, ok with the minor changes to the org.eclipse.draw2d.geometry and org.eclipse.draw2d.graph. Committed to HEAD. We cannot export Export-Package: org.eclipse.draw2d.examples.graph org.eclipse.draw2d.examples.graph is not actually in the GEF builds, so it makes no sense to export it. I think I also have a concern with making the examples "API" by exporting them. As an aside, I know you are likely looking at reusing the draw2d examples in GMF. We already get grief for having the GMF examples/tests depend on the EMF examples, so bad idea starting down the road of depending on the GEF examples. We are actually going to move the GMF examples to not use the EMF examples. So ok to do what you need to not depend on the GEF examples :-)
ugh, reopen to assign the bug to Alex and not the inbox.
(In reply to comment #2) > ok with the minor changes to the org.eclipse.draw2d.geometry and > org.eclipse.draw2d.graph. Committed to HEAD.
